-
Notifications
You must be signed in to change notification settings - Fork 1.9k
DOCPLAN-170: Restructured primary udn assembly for DITA compliance #110244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sjhala-ccs
wants to merge
1
commit into
openshift:main
Choose a base branch
from
sjhala-ccs:docplan-170-primary-udn
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+49
−31
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| // Module included in the following assemblies: | ||
| // | ||
| // * virt/vm_networking/virt-connecting-vm-to-primary-udn.adoc | ||
|
|
||
| :_mod-docs-content-type: REFERENCE | ||
| [id="virt-attaching-vm-to-primary-udn-intro_{context}"] | ||
| = Attach a virtual machine to the primary user-defined network | ||
|
|
||
| [role="_abstract"] | ||
| You can connect a virtual machine (VM) to the primary user-defined network (UDN) by requesting the pod network attachment and configuring the interface binding. | ||
|
|
||
| {VirtProductName} supports the following network binding plugins to connect the network interface to the VM: | ||
|
|
||
| Layer 2 bridge:: The Layer 2 bridge binding creates a direct Layer 2 connection between the VM's virtual interface and the virtual switch of the UDN. | ||
|
|
||
| Passt:: The Plug a Simple Socket Transport (passt) binding provides a user-space networking solution that integrates seamlessly with the pod network, providing better integration with the {product-title} networking ecosystem. | ||
| + | ||
| Passt binding has the following benefits: | ||
|
|
||
| * You can define readiness and liveness HTTP probes to configure VM health checks. | ||
| * You can use Red Hat Advanced Cluster Security to monitor TCP traffic within the cluster with detailed insights. | ||
|
|
||
| :FeatureName: Using the passt binding plugin to attach a VM to the primary UDN | ||
| include::snippets/technology-preview.adoc[] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| // Module included in the following assemblies: | ||
| // | ||
| // * virt/vm_networking/virt-connecting-vm-to-primary-udn.adoc | ||
|
|
||
| :_mod-docs-content-type: REFERENCE | ||
| [id="virt-creating-primary-udn-cli-intro_{context}"] | ||
| = Create a primary user-defined network by using the CLI | ||
|
|
||
| [role="_abstract"] | ||
| You can create a primary `UserDefinedNetwork` or `ClusterUserDefinedNetwork` CRD by using the CLI. After you define the custom primary overlay network, you can create namespaces that are associated with the cluster-scoped UDN. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| // Module included in the following assemblies: | ||
| // | ||
| // * virt/vm_networking/virt-connecting-vm-to-primary-udn.adoc | ||
|
|
||
| :_mod-docs-content-type: REFERENCE | ||
| [id="virt-creating-primary-udn-web-intro_{context}"] | ||
| = Create a primary user-defined network by using the web console | ||
|
|
||
| [role="_abstract"] | ||
| You can use the {product-title} web console to create a primary namespace-scoped `UserDefinedNetwork` or a cluster-scoped `ClusterUserDefinedNetwork` CRD. The UDN serves as the default primary network for pods and VMs that you create in namespaces associated with the network. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment re CRD, not sure if we need to spell it out |
||
|
|
||
| After you define the custom primary overlay network, you can create namespaces that are associated with the cluster-scoped UDN. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you need to spell out CRD on first use in the module?
Also, I'd maybe specify which CLI this is referring to, e.g. use the {oc-first} attribute if it's
oc