Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion internal/ai/analyzer.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"context"
"encoding/json"
"fmt"
"io"
"log/slog"

"github.com/optiqor/kerno/internal/doctor"
Expand Down Expand Up @@ -35,11 +36,15 @@ func NewAnalyzer(cfg AnalyzerConfig) *DefaultAnalyzer {
if privacy == "" {
privacy = PrivacySummary
}
logger := cfg.Logger
if logger == nil {
logger = slog.New(slog.NewTextHandler(io.Discard, nil))
}
return &DefaultAnalyzer{
provider: cfg.Provider,
cache: cfg.Cache,
privacy: privacy,
logger: cfg.Logger,
logger: logger,
}
}

Expand Down
16 changes: 16 additions & 0 deletions internal/ai/analyzer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,22 @@ func TestAnalyzerHappyPath(t *testing.T) {
}
}

func TestAnalyzerUsesDiscardLoggerWhenNil(t *testing.T) {
prov := &scriptedProvider{text: `{"summary":"ok"}`}

a := NewAnalyzer(AnalyzerConfig{Provider: prov})
if a.logger == nil {
t.Fatal("logger should default when omitted")
}
resp, err := a.Analyze(context.Background(), doctor.AnalysisRequest{Signals: emptySignals()})
if err != nil {
t.Fatalf("Analyze error: %v", err)
}
if resp.Summary != "ok" {
t.Errorf("Summary = %q, want ok", resp.Summary)
}
}

func TestAnalyzerMarkdownFencedJSON(t *testing.T) {
prov := &scriptedProvider{text: "Here you go:\n```json\n{\"summary\":\"ok\"}\n```\n"}

Expand Down
Loading