Skip to content

fix(ai): default analyzer logger when omitted#162

Merged
btwshivam merged 1 commit into
optiqor:mainfrom
iccccccccccccc:fix-ai-analyzer-nil-logger
Jun 6, 2026
Merged

fix(ai): default analyzer logger when omitted#162
btwshivam merged 1 commit into
optiqor:mainfrom
iccccccccccccc:fix-ai-analyzer-nil-logger

Conversation

@iccccccccccccc

Copy link
Copy Markdown
Contributor

Fixes #126

Changes

  • Default AnalyzerConfig.Logger to a discard slog logger when omitted
  • Add coverage proving NewAnalyzer can run Analyze without a caller-provided logger

Verification

  • go test ./internal/ai -count=1
  • go test ./... -count=1

Signed-off-by: icc <iccccccccccccc@users.noreply.github.com>
@iccccccccccccc iccccccccccccc requested a review from btwshivam as a code owner May 31, 2026 15:05
@github-actions

Copy link
Copy Markdown

🚀 First PR — welcome aboard!

A few things to expect:

  1. CI: every PR runs build + race tests + lint + (eventually) the kernel matrix. If something fails, the log will tell you exactly which gate.
  2. DCO: every commit needs Signed-off-by:git commit -s adds it automatically.
  3. Conventional Commits: PR titles like feat(doctor): add new rule or fix(bpf): handle X. We squash-merge by default.
  4. Review: a maintainer will review within 72 hours. Suggestions are conversations, not orders — push back if something doesn't fit your context.

If you get stuck, reply here or jump to Discussions. We want this PR to land.

@github-actions github-actions Bot added level:critical Touches BPF, security, or release surfaces (auto-applied) testing Tests and test coverage area/integrations External integrations (sinks, exports, CI) labels May 31, 2026
@btwshivam

Copy link
Copy Markdown
Member

/ok-to-test

@github-actions github-actions Bot added the ok-to-test External PR approved to run CI label May 31, 2026
@github-actions

Copy link
Copy Markdown

No pending workflow runs found on ead09dd. Label applied. If CI should be running but isn't, push a fresh commit.

@btwshivam btwshivam left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working..

@btwshivam

Copy link
Copy Markdown
Member

/lgtm

@btwshivam btwshivam merged commit 59c6e08 into optiqor:main Jun 6, 2026
9 of 10 checks passed
@btwshivam btwshivam added the gssoc:approved Counted toward leaderboard label Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/integrations External integrations (sinks, exports, CI) gssoc:approved Counted toward leaderboard level:critical Touches BPF, security, or release surfaces (auto-applied) ok-to-test External PR approved to run CI testing Tests and test coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(ai): analyzer panics when constructed with nil logger

2 participants