PART 2: Rewrite bash scripts to python - After #498+#505#499
Conversation
okurz
force-pushed
the
feature/bash_to_python4
branch
from
4289b5f to
4629b34
Compare
okurz
force-pushed
the
feature/bash_to_python4
branch
from
4629b34 to
513f245
Compare
I would prefer one or multiple more descriptive namespaces, rather than making it even more cryptic. |
meaning what, to keep "src/os_autoinst_scripts/"? |
okurz
changed the title
Martchus
left a comment
Martchus
left a comment
There was a problem hiding this comment.
Looks generally good so far.
|
This pull request is now in conflicts. Could you fix it? 🙏 |
okurz
force-pushed
the
feature/bash_to_python4
branch
from
513f245 to
ace140e
Compare
|
This pull request is now in conflicts. Could you fix it? 🙏 |
okurz
force-pushed
the
feature/bash_to_python4
branch
from
ace140e to
d8ecbb4
Compare
|
This pull request is now in conflicts. Could you fix it? 🙏 |
okurz
force-pushed
the
feature/bash_to_python4
branch
from
d8ecbb4 to
229bf67
Compare
okurz
force-pushed
the
feature/bash_to_python4
branch
2 times, most recently
from
5bc69c6 to
e32b613
Compare
Also adding a "RUNNER" make variable that defaults to "uv run" but can also be overwritten, e.g. to just an empty string to use the current Python environment.
Verified manually with ``` python3 src/os_autoinst_scripts/chat_notify.py matrix.org "test message from okurz" "$token" "$room_id" ``` which sent a message to a matrix room.
okurz
force-pushed
the
feature/bash_to_python4
branch
from
e32b613 to
d482ff2
Compare
3 participants
After
One main open point is where we should place the Python files. It would be good to have them in a sub-directory and a usual Python practice is to use a properly named package derived from the directory name so "src/os_autoinst_scripts/" sounds correct but is also rather long and also means for testing we need to adjust the Python import path. How about just "oas/" for (Os-Autoinst-Scripts) and ditch the "src/"?