Skip to content

PART 1: Add dependencies for modern Python development#505

Draft
okurz wants to merge 4 commits into
os-autoinst:masterfrom
okurz:feature/bash_to_python5
Draft

PART 1: Add dependencies for modern Python development#505
okurz wants to merge 4 commits into
os-autoinst:masterfrom
okurz:feature/bash_to_python5

Conversation

@okurz

@okurz okurz commented Jan 8, 2026

Copy link
Copy Markdown
Member
  • feat(ci): Simplify deps setup with uv
  • feat(pyproject.toml): Add config for proper python package paths
  • feat(Makefile): Add more Python related targets using "uv"
  • feat(pyproject.toml): Add dependencies in preparation for typecheck+maintainability checks
  • feat(pyproject.toml): Enable dependencies for modern scripts (typer+httpx)
  • fix(test_trigger_bisect_jobs): fix "path" style issue

@Martchus Martchus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these dependencies already required? If not I wouldn't separate adding them from the actual changes requiring them.

Comment thread .github/workflows/ci.yml Outdated
- uses: astral-sh/setup-uv@v7
with:
enable-cache: true
- run: uv sync

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect to find also uv.lock in the repo. otherwise what the us is syncing?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same is in https://github.com/openSUSE/qem-bot/blob/master/.github/workflows/ci.yml#L22 this installs all necessary dependencies

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which also doesnt have a uv.lock. which means that it creates a new one each time is run likely. Both repos should contain the uv.lock. Then the ci should see this and run exactly the same as you run in your workstation

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so as well, uv.lock is necessary for reproducible Python environments.

@okurz

okurz commented Jan 8, 2026

Copy link
Copy Markdown
Member Author

Are these dependencies already required? If not I wouldn't separate adding them from the actual changes requiring them.

the dependencies would only be required in #499

@Martchus Martchus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I say we should add the dependencies only as needed. At least for me it makes no sense to approve this independently from the actual code that I haven't looked at.

@okurz okurz marked this pull request as draft February 24, 2026 19:34
@okurz okurz force-pushed the feature/bash_to_python5 branch from e392ac5 to 70d2328 Compare April 28, 2026 19:43
@os-autoinst os-autoinst deleted a comment from mergify Bot Apr 28, 2026
@okurz okurz force-pushed the feature/bash_to_python5 branch from 70d2328 to 8c3b874 Compare May 6, 2026 12:50
@mergify

mergify Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

This pull request is now in conflicts. Could you fix it? 🙏

@okurz okurz force-pushed the feature/bash_to_python5 branch from 8c3b874 to 53e75e8 Compare May 8, 2026 19:46
@mergify

mergify Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

This pull request is now in conflicts. Could you fix it? 🙏

@okurz okurz force-pushed the feature/bash_to_python5 branch from 53e75e8 to d3e8180 Compare May 21, 2026 19:50
@okurz okurz force-pushed the feature/bash_to_python5 branch 2 times, most recently from b15d253 to 1ad0b20 Compare June 15, 2026 13:25
@okurz okurz force-pushed the feature/bash_to_python5 branch from 1ad0b20 to 1bbda3a Compare June 16, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants