Skip to content

fix(jobs): trust Pi project resources - #152

Merged
owainlewis merged 3 commits into
mainfrom
fix/pi-unattended-project-trust
Jul 25, 2026
Merged

fix(jobs): trust Pi project resources#152
owainlewis merged 3 commits into
mainfrom
fix/pi-unattended-project-trust

Conversation

@owainlewis

Copy link
Copy Markdown
Owner

Summary

  • add explicit configured, unattended, and evaluator modes to the Pi runner
  • pass --approve for unattended Pi jobs so project-local skills and settings load
  • pass --no-approve for evaluators while leaving chat trust behavior unchanged

Why

Pi non-interactive runs do not show a project trust prompt. Under the default trust setting, jobs silently ignored project-local .agents/skills and .pi resources even though jobs run from the assistant repository.

Test plan

  • cargo fmt --check
  • git diff --check
  • cargo test pi::tests (11 passed)
  • cargo test --all-targets (331 unit tests plus integration and documentation tests passed)
  • cargo clippy --all-targets -- -D warnings
  • fresh independent review: Approve, no blocker or important findings

Risks

The deployed Pi executable must support --approve and --no-approve. Verified against installed Pi 0.80.10.

Related issue

None.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a2bb3bf659

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/pi.rs Outdated
@owainlewis
owainlewis force-pushed the fix/pi-unattended-project-trust branch from 3ea2c4f to f5057ee Compare July 25, 2026 20:33
@owainlewis
owainlewis merged commit 5833189 into main Jul 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant