Repository navigation
build(deps): update project dependencies, Git sources and CI tooling - #281
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 32 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review Please review the dependency migrations, Wasmi validation/dispatch safety, runtime shortcut initialization, retained IndexedDB compatibility and the narrow gpui-pre-web/web-sys compatibility patch. This draft preserves the merged animated WebP decoder; the animation scheduler remains a separate issue. |
|
The GPUI 0.3.10 upgrade also includes the upstream negative font-cache fix: The earlier GUI profile recorded 190,284 allocations in the negative-cache subtree, but only 27,172 bytes at peak and 1 of 265 CPU samples in the clone path. A separate 0.3.4 reproducer performing one million resolutions recorded six million allocations / 365 MB cumulative allocation for missing fonts versus zero for an available font, with a transient 122-byte peak and no retention. These establish the repeated-allocation mechanism, not a measured 0.3.4-to-0.3.10 improvement or an overall GUI speedup. The upgrade should remove that repeated churn; any numerical estimate of GUI improvement still requires a controlled before/after comparison. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Refresh the 21 Cargo manifests across six workspaces and the icon-generation tooling against current stable registry releases and upstream refs checked on 2026-10-29. This includes GPUI 0.3.10, usage-rs 7.1.3, Wasmi 2.0.0, tray-icon 0.26.1 and core-foundation 0.10.1. Refresh external lockfiles and CI action SHAs/tool pins, including wasm-bindgen CLI 0.2.129, cargo-nextest 0.9.150, Trunk 0.22.1 and shared-WASM nightly 2026-10-29. Pin optional icon-generation tools to Pillow 13.0.0 and oxipng 10.2.1; the generator passed in a temporary copy without changing the checked-in icons. The project's own release version is unchanged.
Git lockfile pins resolve whatsapp-rust/main to 1fcb58a272334604261eb23f5e2a3f1b54059a33 and GPUI Kit/main to 944803984cf0ba3111861d6e1aa9d6265c109ff9. Keep the whatsapp-rust family on one branch source. Integrate main e6e3020, preserving the animated WebP decoder and subsequent sticker/media fixes. No animation scheduler is added.
Adapt extensible upstream fixtures, shutdown reports, GPUI scroll callbacks and OS-dependent shortcut loading. Enable Wasmi's bytecode validation and auto-dispatch explicitly: without auto-dispatch, a plugin loop overflows the host stack in an unoptimized build. Existing sandbox tests verify fuel and resource limits.
Exceptions are deliberate: retain sqlite-wasm-rs 0.5.5 and sqlite-wasm-vfs 0.2.0 because VFS 0.3 removes the IndexedDB backend holding existing browser databases. Upgrading that pair requires a data migration. Keep the additive getrandom 0.2.17 compatibility backend alongside 0.4.3. Upstream pins four RTC crates to 0.21.0-beta.2, crypto-common pins generic-array 0.14.7, and wasm-bindgen's optional coverage path pins minicov 0.3.8.
The published gpui-pre-web 0.3.10 uses floating-point arguments for get_image_data, which web-sys 0.3.106 changed to integers. Its licensed, checksum-identified vendored copy changes only that call; vendor/gpui-pre-web/README.md records provenance and removal criteria. There is no local font-cache patch.
Qualification at head
e95deb7: the Rust changes pass 2,354 workspace tests with 25 ignored, workspace Clippy, MSRV 1.95 and the shared-memory web type check. Real Chromium runs passed 44 daemon/session tests plus 25 WebCodecs, 6 playout and 1 audio-lifecycle test; the latter three suites also passed with production shared-memory flags and rebuilt std. The complete Trunk web bundle and relocatable asset validation passed. The real SDK/host example smoke test passed. CLI release is 1,485,224 bytes, below 2 MiB. Pinned icon tools passed temporary regeneration/pixel-preservation checks. Codex reviewedc19e5f6without findings; later commits update fixtures, icon-tool pins and explicitly enable macOS notification sounds. Remote macOS CI caught that missing feature on the prior head;e95deb7fixes it. The new head's remote checks and release builds remain pending, so this PR remains draft.Compatibility probe: tested heads #273
3ca1300, #2744a13dfb, #27539e67c0, #2778d61230and #278a5c7c3emerge cleanly with this branch and pass all-target Clippy. The combined run passed 2,364 tests with 27 ignored after excluding two known incompatible #274 assertions. Those compare legacy JSON envelope text and fail when GPUI unifies serde_json/preserve_order; their JSON values remain equivalent. These failures belong to the combined probe, not the standalone #281 branch. #276 was withdrawn and is not included.Summary by cubic
Refreshes dependencies across six Cargo workspaces, Git sources, and CI tooling against current stable registry releases. Updates include GPUI 0.3.10,
usage-rs7.1.3 (renamed fromusage), Wasmi 2.0.0, tray-icon 0.26.1, wasm-bindgen 0.2.129, and cargo-nextest 0.9.150; icon generation now runs through a pinned venv inpackaging/requirements.txt. The project's own release version is unchanged.Breaking dependency changes
usagecrate is nowusage-rs; all imports and shell completion call sites updated.validateandauto-dispatchfeatures; withoutauto-dispatcha plugin loop overflows the host stack in unoptimized builds.on_scrollinstead ofon_scroll_wheel, application shortcuts load throughKeyBinding::loadsince the static constructor no longer resolves the OS-dependent alias, and the sticker test observes the decoder's cache during the drawing phase since assets now belong to the view currently drawing.shutdownnow returns aShutdownReport; call sites log observations through a newreport_shutdownhelper, the outgoing-call fixture adapts to early answers being authenticated before device selection, and group notices are constructed through upstream builders sincePromote/Demotegained fields.Deliberate exceptions
gpui-pre-web0.3.10 with one patch: web-sys 0.3.106 changedget_image_datacoordinates and sizes to integers while the published crate passes floats. Provenance and removal criteria are documented invendor/gpui-pre-web/README.md.Written for commit e95deb7. Summary will update on new commits.