Skip to content

fix(sdk): click-to-pick fills its view, the camera-controls proof waits for the lock (#527) - #782

Merged
pasquelin merged 13 commits into
developfrom
527-examples-draw
Sep 26, 2026
Merged

pasquelin merged 13 commits into
developfrom
527-examples-draw

Conversation

@pasquelin

Copy link
Copy Markdown
Owner

Closes #527

What changed

The examples proof's remaining causes, fixed where they live.

Image change, accepted by the CTO: click-to-pick's framing, on both backends. No engine code changes.

For the measurer: the closer framing may hide a WebGL2 divergence, grid lines under a pixel drawn with no antialiasing. Record WebGPU's share next to WebGL2's.

Proof

  • pnpm run build, then pnpm run check:changed: 15 pass, 0 fail.
  • pnpm run test:changed: 15 pass, 0 fail.
  • pnpm run validate --group typescript: pass.
  • pnpm run validate --group quick: formatting passes. check-file-lines fails on backend/types.ts (202 lines) and world/session/backends.ts (201 lines), both identical to develop after feat(fluids): one GPU particle pool, stepped by a WebGPU compute pass; WebGL2 refused by name until #759 (#420) #776; this branch does not touch them.
  • node scripts/check-pr-size.ts: 49 hand-written lines added.
  • camera/controls/firstPerson.test.ts: the dropped-move test also turns the head back in four moves. The head returns to where it started, and a lost or counted extra move fails it.
  • Browser proofs, run by the measurer after the merge: node tests/browser/test-gpu.ts scripts/docs-examples.browser.ts and tests/browser/renders/native-camera-controls.browser.ts.

Local review before push

Not proven / left out

Lead verification

pasquelin and others added 13 commits September 26, 2026 07:26
…l, and a drift test of the model's call sites (#527)
…, the model's diffuse text shared by both languages, a matcap's unread base map asks no UV, the lock wait drops both listeners (#527)
…ief map and asks no UV for one, as on WebGPU (#527)
… settle for the lock wait, the verdict labelled from the run (#527)
@pasquelin
pasquelin merged commit 41bfbac into develop Sep 26, 2026
7 checks passed
@pasquelin
pasquelin deleted the 527-examples-draw branch September 26, 2026 06:56
@pasquelin pasquelin added the audited Image proved and promise kept (recette) label Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audited Image proved and promise kept (recette)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant