[SOC2] Add TLS 1.3 support alongside TLS 1.2#98
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds explicit TLS 1.3 support to Peridiod’s outbound TLS configuration while keeping TLS 1.2 enabled for compatibility, and introduces a regression test to lock the expected TLS versions list.
Changes:
- Extend the SSL options built in
Peridiod.Config.build_config/2to include both:"tlsv1.2"and:"tlsv1.3". - Add a config test asserting the configured SSL versions include TLS 1.2 and TLS 1.3.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
lib/peridiod/config.ex |
Adds versions: [:"tlsv1.2", :"tlsv1.3"] to the constructed SSL client options. |
test/peridiod/config_test.exs |
Adds a new test verifying the SSL :versions list contains TLS 1.2 and TLS 1.3. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Adds :"tlsv1.3" to the ssl :versions list in build_config/2 so all transports (Tesla HTTP and Slipstream WebSocket) can negotiate TLS 1.3 with OTP 27, while retaining TLS 1.2 for backward compatibility. Also adds a test asserting both versions are present. Closes ENG-1713.
build_config/2 overwrites the ssl keyword list entirely, making the :versions put_new in base_config/1 dead code. Remove it to avoid a misleading second default that doesn't match the live configuration.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Reorder TLS versions to prefer 1.3 over 1.2 - Use membership assertions in test instead of exact list equality
lee-reinhardt
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:"tlsv1.3"to the:versionslist inbuild_config/2so all TLS connections (Tesla HTTP client and Slipstream WebSocket) can negotiate TLS 1.3 on OTP 27, while retaining TLS 1.2 for backward compatibility with older gatewaysbuild_config/2(the actual SSL construction site innew/1) — notbase_config/1, which is overwritten before TLS options take effectTest plan
mix test test/peridiod/config_test.exs— new assertion confirms both:"tlsv1.2"and:"tlsv1.3"present inconfig.ssl[:versions]mix test— full suite passes (252 tests, 0 failures):"tlsv1.3"against staging cloud via:ssl.connection_information/1Closes ENG-1713.