Skip to content

[SOC2] Add TLS 1.3 support alongside TLS 1.2 #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasontwong merged 3 commits into from
May 5, 2026
Merged

[SOC2] Add TLS 1.3 support alongside TLS 1.2 #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51a1b5d
[SOC2] Add TLS 1.3 support alongside TLS 1.2
jasontwong May 1, 2026
e125a02
Remove stale :versions default from base_config/1
jasontwong May 1, 2026
bd8dc00
Address PR review comments on TLS version ordering and test assertion
jasontwong May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/peridiod/config.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,8 @@ defmodule Peridiod.Config do
|> Map.put(:ssl,
server_name_indication: to_charlist(config.device_api_host),
verify: verify,
cacertfile: config.device_api_ca_certificate_path
cacertfile: config.device_api_ca_certificate_path,
versions: [:"tlsv1.3", :"tlsv1.2"]
)
Comment thread
jasontwong marked this conversation as resolved.
Comment thread
jasontwong marked this conversation as resolved.

case config.key_pair_source do
Expand Down Expand Up @@ -413,7 +414,6 @@ defmodule Peridiod.Config do
ssl =
base.ssl
|> Keyword.put_new(:verify, :verify_peer)
|> Keyword.put_new(:versions, [:"tlsv1.2"])
|> Keyword.put_new(:server_name_indication, to_charlist(base.device_api_sni))

%{base | socket: socket, ssl: ssl}
Expand Down
10 changes: 10 additions & 0 deletions test/peridiod/config_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,16 @@ defmodule Peridiod.ConfigTest do
end
end

describe "tls versions" do
test "ssl options include both TLS 1.2 and TLS 1.3" do
with_config_file("test/fixtures/peridio.json", fn ->
config = build_config()
assert :"tlsv1.2" in config.ssl[:versions]
assert :"tlsv1.3" in config.ssl[:versions]
end)
end
end

describe "device_api_verify" do
test "struct default is :verify_peer" do
assert %Peridiod.Config{}.device_api_verify == :verify_peer
Expand Down
Loading