Merge wasm-playground branch into master by Tasty-Kiwi · Pull Request #4 · pewpewlive/hybroid-live

Tasty-Kiwi · 2026-01-15T23:23:00Z

No description provided.

… printing

Copilot

Pull request overview

This pull request merges the wasm-playground branch into master, adding WebAssembly support to enable Hybroid compilation in a browser environment. This allows users to experiment with the Hybroid language through a web-based playground.

Changes:

Added WebAssembly compilation support through a new wasm package and WASM-specific entry point
Enhanced build script to support selective platform builds and added WASM as a build target
Added project context documentation (GEMINI.md) for AI assistants

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
wasm/wasm.go	Implements WASM bindings for browser-based Hybroid compilation, exposing a `hybroidCompile` JavaScript function
main_wasm.go	WASM-specific entry point that registers the compile function and prevents program exit
main_native.go	Added build tag to exclude from WASM builds
utils/build_hybroid.py	Added selective build target support and WASM platform configuration
README.md	Updated build documentation to reflect optional platform parameter
GEMINI.md	Added comprehensive project context documentation for AI assistants

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-15T23:28:36Z

+	generator.ResetGlobalGeneratorValues()
+
+	gen.SetEnv(w.Env().Name, w.Env().Type)
+	gen.GenerateUsedLibaries(w.Env().UsedLibraries)


The method name 'GenerateUsedLibaries' contains a spelling error. It should be 'GenerateUsedLibraries' (with two 'r's). While this appears to be an existing issue in the codebase, this usage propagates the misspelling.

@copilot open a new pull request to apply changes based on this feedback

Copilot · 2026-01-15T23:28:36Z

+	if len(l.GetAlerts()) > 0 {
+		hasError := false
+		for _, a := range l.GetAlerts() {
+			if a.AlertType() == alerts.Error {
+				hasError = true
+				break
+			}
+		}
+
+		msg := formatAlerts(l.GetAlerts(), code)
+		if hasError {
+			return "", fmt.Errorf("%s", msg)
+		}
+		warnings.WriteString(msg)
+	}
+
+	p := parser.NewParser(tokensList)
+	program := p.Parse()
+
+	if len(p.GetAlerts()) > 0 {
+		hasError := false
+		for _, a := range p.GetAlerts() {
+			if a.AlertType() == alerts.Error {
+				hasError = true
+				break
+			}
+		}
+
+		msg := formatAlerts(p.GetAlerts(), code)
+		if hasError {
+			return "", fmt.Errorf("%s", msg)
+		}
+		warnings.WriteString(msg)
+	}
+
+	walker.SetupLibraryEnvironments()
+	w := walker.NewWalker("main.hyb", "main.lua")
+	w.SetProgram(program)
+
+	// Single file compilation, so no other walkers to share context with
+	walkers := make(map[string]*walker.Walker)
+	w.PreWalk(walkers)
+	w.Walk()
+	w.PostWalk()
+
+	if len(w.GetAlerts()) > 0 {
+		hasError := false
+		for _, a := range w.GetAlerts() {
+			if a.AlertType() == alerts.Error {
+				hasError = true
+				break
+			}
+		}
+
+		msg := formatAlerts(w.GetAlerts(), code)
+		if hasError {
+			return "", fmt.Errorf("%s", msg)
+		}
+		warnings.WriteString(msg)
+	}


The duplicate error-checking pattern (lines 75-89, 94-108, 120-134) should be extracted into a helper function to reduce code duplication and improve maintainability. This would make the compile function more concise and easier to maintain.

@copilot open a new pull request to apply changes based on this feedback

Copilot · 2026-01-15T23:28:36Z

+    # Clean previous builds only if building everything
+    if not target:
+        for file in os.listdir("build"):
+            os.remove("build/" + file)


The file removal logic will fail if the build directory contains subdirectories, as os.remove only works with files. Consider using os.path.isfile() to filter only files, or handle the exception when attempting to remove a directory.

Suggested change

os.remove("build/" + file)

path = os.path.join("build", file)

if os.path.isfile(path):

os.remove(path)

Copilot · 2026-01-15T23:28:37Z

+			return "expected 1 argument"
+		}
+		if args[0].Type() != js.TypeString {
+			return "expected string"


The error messages returned to JavaScript callers are very generic ('expected 1 argument', 'expected string'). Consider making these more descriptive, such as 'hybroidCompile expects exactly 1 argument (code as string)' to provide better developer experience for JavaScript users of the API.

Suggested change

return "expected 1 argument"

}

if args[0].Type() != js.TypeString {

return "expected string"

return "hybroidCompile expects exactly 1 argument (code as string)"

}

if args[0].Type() != js.TypeString {

return "hybroidCompile expects its first argument to be a string containing the code to compile"

Copilot · 2026-01-15T23:28:37Z

+	}
+	return sb.String()
+}
+


The compile function lacks a documentation comment. As the core functionality of this package, it should have a comment explaining its purpose, parameters, and return values. Consider adding: '// compile transpiles Hybroid source code to Lua, collecting and formatting any warnings or errors encountered during lexing, parsing, and semantic analysis.'

Suggested change

// compile transpiles Hybroid source code to Lua, collecting and formatting any

// warnings or errors encountered during lexing, parsing, and semantic analysis.

// The input parameter code is the Hybroid source as a string. It returns the

// generated Lua source code, or a non-nil error if a fatal issue is detected.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-02-07T16:04:31Z

@Tasty-Kiwi I've opened a new pull request, #5, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-02-07T16:04:34Z

@Tasty-Kiwi I've opened a new pull request, #6, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan * Fix spelling: GenerateUsedLibaries -> GenerateUsedLibraries Co-authored-by: Tasty-Kiwi <26067386+Tasty-Kiwi@users.noreply.github.com> * Restore test directory files that were accidentally modified Co-authored-by: Tasty-Kiwi <26067386+Tasty-Kiwi@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Tasty-Kiwi <26067386+Tasty-Kiwi@users.noreply.github.com>

* Initial plan * Extract duplicate error-checking pattern into processAlerts helper Co-authored-by: Tasty-Kiwi <26067386+Tasty-Kiwi@users.noreply.github.com> * Remove unnecessary format string in processAlerts Co-authored-by: Tasty-Kiwi <26067386+Tasty-Kiwi@users.noreply.github.com> * Use errors.New instead of fmt.Errorf for pre-formatted strings Co-authored-by: Tasty-Kiwi <26067386+Tasty-Kiwi@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Tasty-Kiwi <26067386+Tasty-Kiwi@users.noreply.github.com>

Tasty-Kiwi added 5 commits January 15, 2026 16:45

Implement wasm support for playground

9da1baa

Refactor error handling in compileWrapper to return errors instead of…

05dd70e

… printing

Add project context and documentation for Hybroid Live

801db80

Update build_hybroid.py to accept platform argument and validate targets

edba121

[wasm] import walker and add warnings to the output

ce3b9a4

Tasty-Kiwi changed the title ~~Merge wasm playground code into master~~ Merge wasm-playground branch into master Jan 15, 2026

Tasty-Kiwi requested a review from Copilot January 15, 2026 23:24

Copilot started reviewing on behalf of Tasty-Kiwi January 15, 2026 23:25 View session

Copilot AI reviewed Jan 15, 2026

View reviewed changes

Tasty-Kiwi and others added 3 commits January 21, 2026 21:00

Update GEMINI.md

d85b7bf

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update wasm/wasm.go

71a433c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update wasm/wasm.go

28e808f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

This was referenced Feb 7, 2026

Fix spelling: GenerateUsedLibaries → GenerateUsedLibraries #5

Merged

Refactor duplicate error-checking pattern in wasm compile function #6

Merged

Copilot AI and others added 2 commits February 7, 2026 18:18

Tasty-Kiwi merged commit d7ba0ef into master Feb 7, 2026
1 check failed

Tasty-Kiwi deleted the wasm-playground branch February 7, 2026 16:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge wasm-playground branch into master#4

Merge wasm-playground branch into master#4
Tasty-Kiwi merged 10 commits into
masterfrom
wasm-playground

Tasty-Kiwi commented Jan 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Jan 15, 2026

Uh oh!

Tasty-Kiwi Feb 7, 2026

Uh oh!

Uh oh!

Copilot AI Jan 15, 2026

Uh oh!

Tasty-Kiwi Feb 7, 2026

Uh oh!

Copilot AI Jan 15, 2026

Uh oh!

Copilot AI Jan 15, 2026

Uh oh!

Copilot AI Jan 15, 2026

Uh oh!

Uh oh!

Copilot AI commented Feb 7, 2026

Uh oh!

Copilot AI commented Feb 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-            os.remove("build/" + file)
+            path = os.path.join("build", file)
+            if os.path.isfile(path):
+                os.remove(path)

+// compile transpiles Hybroid source code to Lua, collecting and formatting any
+// warnings or errors encountered during lexing, parsing, and semantic analysis.
+// The input parameter code is the Hybroid source as a string. It returns the
+// generated Lua source code, or a non-nil error if a fatal issue is detected.

Conversation

Tasty-Kiwi commented Jan 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Tasty-Kiwi Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Tasty-Kiwi Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI commented Feb 7, 2026

Uh oh!

Copilot AI commented Feb 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants