Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Return the result that was already matched by command ID in the synchronous and
asynchronous
start_commandimplementations.Problem
After
GetLastCommandResultreturns the response whose command ID matches thecommand started by this call, the current implementation discards that response
and performs another cursorless lookup. If another command finishes between the
two lookups,
start_commandcan return the newer command's result instead.Change
Return
command_result_response.resultdirectly after the command ID matches.This also avoids one unnecessary RPC. The synchronous client was regenerated
from the asynchronous source with the repository's generation script.
Verification
A deterministic local stub made command A complete successfully and then made
command B the latest failed result before the second lookup. Before this change,
both the synchronous and asynchronous clients returned command B's result.
After this change, both return command A's matched result (2 tests passed).