Repository navigation
fix: unblock reproducible R10 approval-stop validation and define remaining acceptance work - #478
Merged
ShutenOishi merged 1 commit intoOct 31, 2026
Conversation
… remaining-work contract
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and resulting behavior
R10 repeatedly inventories an absent BLOCKED_APPROVAL, but the shared lifecycle has no explicit approval-stop transition. R11 inventories do not define the functional replacements for schedule-only candidate/requalification/reconciliation paths.
Add a pure, evidence-bound PREPARE approval-stop transition, rejecting PUBLISH_DENY substitution, unbound/mismatched/expired requests, completed work and terminal reopening. Commit reason/last stage/safe resume evidence to the immutable State event. Add deterministic 17-target hostile tests against the production lifecycle and CAS adapter, including stale CAS and controlled lost ACK. These tests use in-memory transport; they do not authenticate human approval or perform live App CAS.
Fix seven executable work packages with inputs, procedures, pass/fail criteria and next actions for the nine remaining checkboxes. No new acceptance; 85/94 unchanged. The authenticated approval lookup adapter remains a concrete implementation task, not a completed runtime claim.
Validation
Local lifecycle 5 + CAS adapter 6 + new approval/plan 6 tests PASS. Required resolver runs the new test. New read-only workflow emits an explicitly OFFLINE original receipt on main push; separate keyless Runner downloads the actual provider ZIP, checks CRC/SHA256/original Run/head and reproduces exact JSON.
No publication, schedule deletion/addition, new credentials, branch-protection changes, or successful Run reruns. runtimeEnabled=false / PUBLISH_DENY remain. #311 and #75 remain OPEN. Merge only at successful required CI and expected HEAD; verify original postmerge.