Skip to content

app datasets list by requesting an api - #10

Open
qinqian wants to merge 18 commits into
pinellolab:masterfrom
qinqian:master
Open

qinqian wants to merge 18 commits into
pinellolab:masterfrom
qinqian:master

Conversation

@qinqian

@qinqian qinqian commented Oct 24, 2020

Copy link
Copy Markdown
Contributor

The two app should be run with different ports. The reason why one port is not working is the failure of requests of the api.

@qinqian
qinqian requested a review from davidfstein October 24, 2020 03:02
@davidfstein

Copy link
Copy Markdown
Collaborator

Hi Qian,
This all looks good. The only thing I need is a get_dataset_type endpoint. Right now, when I parse the datasets, there is a file that tells me if the dataset is paga, stream, scanpy, etc. I need this information to render the visualization correctly. The following API would be ideal.

def get_dataset_type(db_name):
    ## type is one of ['STREAM', 'PAGA', 'SCANPY', and anything else we support in the future]
    return jsonify({"type": type})

@qinqian

qinqian commented Dec 1, 2020

Copy link
Copy Markdown
Contributor Author

Hi David,

Please see my latest commits, I use a simple way to implement the interface by local file name and extend to other two tools with demo in the function docstring. Happy to discuss with you later.

Best,
Qian

@davidfstein

Copy link
Copy Markdown
Collaborator

@qinqian This looks great! I'll test it out and merge it

@qinqian

qinqian commented Oct 27, 2021

Copy link
Copy Markdown
Contributor Author

Please use this pull request to merge the fix of Seurat 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants