Skip to content

Clarify TiKV large-row limit in transaction restraints (#23338)#23348

Merged
ti-chi-bot[bot] merged 4 commits into
pingcap:release-8.5from
ti-chi-bot:cherry-pick-23338-to-release-8.5
Jul 23, 2026
Merged

Clarify TiKV large-row limit in transaction restraints (#23338)#23348
ti-chi-bot[bot] merged 4 commits into
pingcap:release-8.5from
ti-chi-bot:cherry-pick-23338-to-release-8.5

Conversation

@ti-chi-bot

@ti-chi-bot ti-chi-bot commented Jul 23, 2026

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #23338

What is changed, added or deleted? (Required)

Clarify in develop/dev-guide-transaction-restraints.md that increasing the TiDB large-row limit alone is not enough. When a single write request exceeds TiKV raftstore.raft-entry-max-size, TiKV rejects the request, so users need to adjust the TiKV limit together with the TiDB row-size limit.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Clarified large transaction restrictions by documenting TiKV’s per-write request size limit (default 8 MiB).
    • Added guidance to adjust both TiDB’s and TiKV’s size settings when large rows cause TiKV to reject a request.

@ti-chi-bot ti-chi-bot added area/develop This PR relates to the area of TiDB App development. contribution This PR is from a community contributor. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Jul 23, 2026
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 79b84e2b-f326-4290-be34-e97508d88bef

📥 Commits

Reviewing files that changed from the base of the PR and between 90d6b86 and afc99f9.

📒 Files selected for processing (1)
  • develop/dev-guide-transaction-restraints.md

📝 Walkthrough

Walkthrough

The transaction restraints guide now documents TiKV’s default 8 MiB per-write-request limit and advises adjusting it together with TiDB’s transaction entry size limit for large rows.

Changes

Transaction restraints documentation

Layer / File(s) Summary
Document combined transaction size limits
develop/dev-guide-transaction-restraints.md
Adds TiKV’s raftstore.raft-entry-max-size limit and guidance to adjust it alongside tidb_txn_entry_size_limit for large rows.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • pingcap/docs#23338: Updates the same transaction restraints section with related TiKV request-size guidance.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the doc change about the TiKV large-row limit in transaction restraints.
Description check ✅ Passed The description covers the required change, affected versions, and related links, so it mostly matches the template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 337d544f-376d-42ea-80d1-3bece415aa8d

📥 Commits

Reviewing files that changed from the base of the PR and between afde45c and 90d6b86.

📒 Files selected for processing (1)
  • develop/dev-guide-transaction-restraints.md

Comment thread develop/dev-guide-transaction-restraints.md Outdated
Comment thread develop/dev-guide-transaction-restraints.md Outdated
@qiancai

qiancai commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

/approve

@qiancai qiancai added the needs-cherry-pick-master Should cherry pick this PR to master branch. label Jul 23, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Jul 23, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit 499c12a into pingcap:release-8.5 Jul 23, 2026
12 checks passed
@ti-chi-bot
ti-chi-bot Bot deleted the cherry-pick-23338-to-release-8.5 branch July 23, 2026 09:02
@ti-chi-bot

Copy link
Copy Markdown
Member Author

In response to a cherrypick label: new pull request created to branch master: #23351.
But this PR has conflicts, please resolve them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/develop This PR relates to the area of TiDB App development. contribution This PR is from a community contributor. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-master Should cherry pick this PR to master branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants