Clarify TiKV large-row limit in transaction restraints (#23338) (#23348)#23351
Clarify TiKV large-row limit in transaction restraints (#23338) (#23348)#23351ti-chi-bot wants to merge 1 commit into
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
area/develop
|
@ti-chi-bot This PR has conflicts, I have hold it. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
📝 WalkthroughWalkthroughThe transaction restrictions guide clarifies that large-row handling requires adjusting TiDB’s ChangesTransaction restrictions documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: f1b24695-eb3a-4031-bc3b-a57b66b5f98c
📒 Files selected for processing (1)
develop/dev-guide-transaction-restraints.md
| <<<<<<< HEAD | ||
| - Note that TiKV also limits the data size of a single write request. If the data size of a single write request exceeds [`raftstore.raft-entry-max-size`](/tikv-configuration-file.md#raft-entry-max-size), which is `8 MiB` by default, TiKV rejects the request. When a single row is large, you need to adjust both `tidb_txn_entry_size_limit` in TiDB and `raftstore.raft-entry-max-size` in TiKV. | ||
| ======= | ||
| - Note that TiKV also limits the data size of a single write request. If the data size of a single write request exceeds [`raftstore.raft-entry-max-size`](/tikv-configuration-file.md#raft-entry-max-size), which is `8 MiB` by default, TiKV rejects the request. When a single row is large, you need to adjust both `tidb_txn_entry_size_limit` for TiDB and `raftstore.raft-entry-max-size` for TiKV. | ||
| >>>>>>> 499c12a01f (Clarify TiKV large-row limit in transaction restraints (#23338) (#23348)) |
There was a problem hiding this comment.
🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win
Resolve the merge conflict and preserve version-specific TiDB settings.
These lines contain committed conflict markers and duplicate content. They also direct pre-v7.6 users to tidb_txn_entry_size_limit, which is unavailable before v7.6.0; those versions use performance.txn-entry-size-limit.
| <<<<<<< HEAD | |
| - Note that TiKV also limits the data size of a single write request. If the data size of a single write request exceeds [`raftstore.raft-entry-max-size`](/tikv-configuration-file.md#raft-entry-max-size), which is `8 MiB` by default, TiKV rejects the request. When a single row is large, you need to adjust both `tidb_txn_entry_size_limit` in TiDB and `raftstore.raft-entry-max-size` in TiKV. | |
| ======= | |
| - Note that TiKV also limits the data size of a single write request. If the data size of a single write request exceeds [`raftstore.raft-entry-max-size`](/tikv-configuration-file.md#raft-entry-max-size), which is `8 MiB` by default, TiKV rejects the request. When a single row is large, you need to adjust both `tidb_txn_entry_size_limit` for TiDB and `raftstore.raft-entry-max-size` for TiKV. | |
| >>>>>>> 499c12a01f (Clarify TiKV large-row limit in transaction restraints (#23338) (#23348)) | |
| - Note that TiKV also limits the data size of a single write request. If the data size of a single write request exceeds [`raftstore.raft-entry-max-size`](/tikv-configuration-file.md#raft-entry-max-size), which is `8 MiB` by default, TiKV rejects the request. When a single row is large, you need to adjust both the TiDB row-size limit (`performance.txn-entry-size-limit`, or `tidb_txn_entry_size_limit` starting from v7.6.0) and `raftstore.raft-entry-max-size` in TiKV. |
As per path instructions, use a committable suggestion for this contiguous Markdown fix.
Sources: Coding guidelines, Path instructions
1 participant
This is an automated cherry-pick of #23348
This is an automated cherry-pick of #23338
What is changed, added or deleted? (Required)
Clarify in
develop/dev-guide-transaction-restraints.mdthat increasing the TiDB large-row limit alone is not enough. When a single write request exceeds TiKVraftstore.raft-entry-max-size, TiKV rejects the request, so users need to adjust the TiKV limit together with the TiDB row-size limit.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?
Summary by CodeRabbit
tidb_txn_entry_size_limitand TiKV’sraftstore.raft-entry-max-sizeshould be adjusted together.