Skip to content

Fix BoLA A19 sample attribution - #421

Merged
iskandr merged 1 commit into
mainfrom
fix-bola-a19-414
Sep 4, 2026
Merged

Fix BoLA A19 sample attribution#421
iskandr merged 1 commit into
mainfrom
fix-bola-a19-414

Conversation

@iskandr

@iskandr iskandr commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • restore 2824TP's measured A19 genotype to BoLA-2*016:01 BoLA-6*014:02
  • preserve the paper's three BoLA-6*014:01 peptide predictions as exact, predicted observation restrictions
  • add source-backed peptide-to-2824TP attribution and allow resolved rows to carry a curated sample label without rewriting their restriction
  • document and regression-test the separation between sample typing, row restriction, and restriction evidence
  • bump Hitlist to 1.57.1

Primary-source resolution

Results 3.2 of Connelley/Sheldrake 2022 and the independent Vasoya et al. A19 definition identify A19 as BoLA-2*016:01 plus BoLA-6*014:02. However, Connelley Table 3 and Supplementary Data 2.1 assign the three retained peptides to BoLA-6*014:01 by prediction. The supplement contains 23 *014:01 predictions, all in 2824TP runs, and no *014:02 predictions.

IEDB faithfully retained the paper's three final-table predictions, so this is not an upstream IEDB ingestion defect and no upstream issue was filed. The published source-level discrepancy remains explicit in the curation note and issue discussion; this PR represents both facts without declaring the alleles equivalent.

Verification

  • ./format.sh
  • ./lint.sh
  • ./test.sh — 1,190 passed, one expected warning
  • pytest -q tests/test_build_smoke.py — 2 passed
  • real scan of the 7.77 GB IEDB export — exactly the three expected PMID 36423003 rows retained Bota-6*014:01, exact, and predicted, each attributed to 2824TP
  • sample_ploidy_audit() — clean corpus-wide

Closes #414

@iskandr
iskandr merged commit c43937b into main Sep 4, 2026
5 checks passed
@iskandr
iskandr deleted the fix-bola-a19-414 branch September 4, 2026 11:36
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 33868178861

Coverage remained the same at 83.005%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 8 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

8 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
curation.py 8 94.49%

Coverage Stats

Coverage Status
Relevant Lines: 8132
Covered Lines: 6750
Line Coverage: 83.01%
Coverage Strength: 0.83 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PMID 36423003: BoLA-6*014:01 vs *014:02, and BoLA-2*008:01 has no rows

2 participants