Preserve study-specific THP-1 HLA typing - #422
Merged
Merged
Conversation
Coverage Report for CI Build 33881810600Coverage remained the same at 83.005%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Contributor
Author
|
Merged and deployed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(
HLA-A*02:01,HLA-B*15:11,HLA-C*03:03)regressions
Source resolution
Nicholas 2022 S1 repeats A02:01, B15:11, and C03:03 in both class-I haplotypes and the Results
describe its THP-1 culture as homozygous. Ghosh 2020 reports A02:01/A24:02 and
B15:11/B*35:01 for a culture obtained as DSMZ ACC-16. Cellosaurus preserves both typing records
and the documented THP-1 discrepancy, so the truthful representation is per-study typing rather
than a registry-wide superset.
No upstream issue is warranted: the source records expose the divergent typings; Hitlist was
substituting the heterozygous superset into the Nicholas study.
Verification
./format.sh./lint.sh./test.sh— 1,192 passed, one expected warningpytest -q tests/test_build_smoke.py— 2 passedclass-pool sample metadata
sample_ploidy_audit()is emptyCloses #416