Skip to content

Fix assay routing and provenance CLI parity - #423

Merged
iskandr merged 1 commit into
mainfrom
fix-assay-routing-and-provenance-cli
Sep 4, 2026
Merged

Fix assay routing and provenance CLI parity#423
iskandr merged 1 commit into
mainfrom
fix-assay-routing-and-provenance-cli

Conversation

@iskandr

@iskandr iskandr commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • route purified-MHC half-life measurements to binding.parquet from the structured IEDB assay method and response fields
  • bump the observations artifact contract so existing cached indexes rebuild with the corrected routing
  • expose one shared MHC allele provenance vocabulary and use it for the MS, binding, and training CLI choices
  • bump Hitlist to 1.58.0

Source audit

The registered 2026-03-30 IEDB snapshot differs from #418's original count. PMID 36423003 has 146 cellular-MHC mass-spectrometry observations and 76 purified-MHC half-life measurements. The old classifier routed 66 of the latter to binding based on their qualitative values but leaked 10 plain-Positive rows into observations. The same structured signature identifies 942 leaked rows corpus-wide.

The IEDB source already records the modality accurately, so this is an internal Hitlist classification defect rather than an upstream data problem. The corrected counts are documented on #418.

Verification

  • isolated full rebuild: all 942 matching assay IRIs moved from MS to binding; zero remain in MS
  • PMID 36423003 after rebuild: 146 MS observations and 76 binding observations
  • ./format.sh
  • ./lint.sh
  • ./test.sh — 1,198 passed
  • pytest -q tests/test_build_smoke.py — 2 passed

Closes #418.
Closes #419.

@iskandr
iskandr merged commit 8fd02b3 into main Sep 4, 2026
5 checks passed
@iskandr
iskandr deleted the fix-assay-routing-and-provenance-cli branch September 4, 2026 16:23
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 33894117529

Coverage increased (+0.01%) to 83.016%

Details

  • Coverage increased (+0.01%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 46 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

46 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
curation.py 46 94.52%

Coverage Stats

Coverage Status
Relevant Lines: 8137
Covered Lines: 6755
Line Coverage: 83.02%
Coverage Strength: 0.83 hits per line

💛 - Coveralls

@iskandr

iskandr commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

Deployed Hitlist 1.58.0 from clean main at merge commit 8fd02b3.

Release verification:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI rejects valid peptide_attribution MHC provenance filter Purified-MHC half-life assays leak into observations.parquet

2 participants