Normalize allele-set filters consistently across evidence exports - #433
Merged
Conversation
Coverage Report for CI Build 34137341462Coverage decreased (-0.01%) to 83.245%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions103 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MS and binding exports duplicated the allele-set membership filter without the loader's normalization, so
A*02:01returned no evidence whileHLA-A*02:01succeeded. Both exporters now forward allele-set and provenance filters to their shared loaders, preserving comma-separated list inputs and removing the duplicate filtering code. Training exports inherit the same selection and empty-input validation.Forty-two parity regressions compare raw-loader and exported assay identities across canonical/bare/case-variant alleles, provenance filters, list input forms, all training evidence modes, and empty allele queries. Version: 1.58.4.
Validation:
./format.shand./lint.shpass. The combined export suite passes 200 tests;./test.shpasses all 1,280 default-suite tests with one expected warning.Closes #427.
Release verification: every PR CI job passed across Python 3.9–3.12, including all 24 corpus integration tests on 3.11. Merged as
13c37c0;./deploy.shran from clean main and passed all 1,304 tests with one expected warning. Both the wheel and source archive are published at https://pypi.org/project/hitlist/1.58.4/ and their SHA-256 hashes match the local build artifacts.The four-PR data-consistency series is shipped: #429 / 1.58.1, #431 / 1.58.2, #432 / 1.58.3, and #433 / 1.58.4. All seven original bug reproductions pass. The next prioritized block is #386 (species filters in every export), followed by #373 (ignored sample-curation fields); dependency and evidence constraints are recorded in
tasks/todo.md.