Repository navigation
Driven-run start: check the commander's z against .gps FloorZ (#292) - #293
Merged
Merged
Conversation
…mutations, vet, full test run and docs still to do
…out another unit (#292)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #292.
A driven run's start moved the commander with
.go xyzand then checked only the flat distance, so a wrong z (under a shelf or the terrain) went unnoticed and the bots followed the commander into the floor.What changed:
.go xyzthe start selects the commander by GUID, then sends.gpsand reads the reply's FloorZ..go xyzonce at the floor height; if the floor is far from the target (another layer) the start is refused with a plain reason.Tests:
go test ./...passes. New tests cover under-the-ground, the single re-send, a floor far from the target, a reply about another unit, the select-before-.gpsorder, and booking each GPS line. Mutations of each check turn a test red.Reviews: Opus cold review SHIP, Codex review found no actionable issue.
Known limits (minor, follow-up):
Z:from the same reply would be more robust..gpsand the re-send are now booked too.