Repository navigation
feat(together): Watch Together on Android TV and phone (phase 1) - #533
Open
playbridgeapp wants to merge 4 commits into
Open
playbridgeapp wants to merge 4 commits into
playbridgeapp wants to merge 4 commits into
Conversation
Bridge the Rust engine to Kotlin and build Watch Together into both Android apps. - FFI: pb_together_* JSON handle and JNI (cast/ffi `together` feature), pairing code QR modules, explicit rustls config for Android. - Engine: add own devices by key, switch a member between screen and remote mid-party, stop the party at the end of the video, never seek past a device's end, leave sub-500 ms gaps alone while paused, and ignore Play/Pause that change nothing. - TV: Settings > Watch Together (code + QR, join prompt, party state), party mode in the player (room drives playback, no history or resume), join from a paired phone over the LAN. - Phone: Watch together screen (start, join, invite link handling, add the connected TV or a TV by code, controls, lock, policy, requests, sign-in sharing), cast sheet plays in the party, and "Watch on this phone" plays along in the phone player with party controls. - Protocol: watch_together_join / watch_together_joined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1 of Watch Together (
docs/design-watch-together.md): the Rust engine from #532, bridged into the Android TV and phone apps.What's in it
FFI and engine
cast/ffitogetherfeature:pb_together_*JSON handle plus JNI (TogetherNative), the pairing code's QR as modules, and an explicit rustls/webpki config (the Android platform verifier needs JNI setup, and both ring and aws-lc are linked).TV
watch_together_join/watch_together_joined, capabilitywatch_together_v1).Phone
Tested
Not tested on a device
Not in this PR
amehlaworkers.devsubdomain until a PlayBridge domain is decided.