Escalate 0.1.0 deprecations, drop purrr, modernize tests - #103
Merged
Conversation
`is.term()`, `is.incomplete_terms()`, `is.inconsistent_terms()`, `parameters()`, `parameters<-()`, `set_parameters()` and `tdims()` have warned since term 0.1.0 (2020-01-15) and now error. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Replace the single `purrr::map_chr()` call with `vapply()`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Migrate `test-print.R` from the superseded `verify_output()` (removing `tests/testthat/out/`) and convert `expect_error()`/`expect_warning()` message checks to snapshot tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The wording of chk's S3 class errors differs between CRAN chk (0.10.0) and the development version, so snapshots written locally fail on CI. Use `expect_error()` with a version-stable pattern and class instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is.term(),is.incomplete_terms(),is.inconsistent_terms(),parameters(),parameters<-(),set_parameters()andtdims()now error viadeprecate_stop(); they had warned since term 0.1.0 (2020-01-15).purrr::map_chr()call withvapply().test-print.Rfrom the supersededverify_output()toexpect_snapshot()and convertexpect_error()/expect_warning()message checks to snapshot tests.Note: mcmcr re-exports
term::parametersandterm::parameters<-and tests them; a companion mcmcr PR removes these and must reach CRAN before term is released. nlist and the other CRAN reverse dependency code are unaffected.devtools::check(): 0 errors, 0 warnings, 0 notes.🤖 Generated with Claude Code