updater: boot recovery waits for a robot that is still starting, the way the gate does - #197
Open
Nixxx19 wants to merge 1 commit into
Conversation
…way the gate does
Contributor
Author
|
hi @pierre-rouanet, mind a look at this one when you get a chance? it stops the updater rolling back a release that was only slow to start. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #196
the apply gate polls robotd for the whole health timeout. boot recovery asks once with a 2s timeout and reverts on whatever it hears, so a robot that's still loading its policies reads as a release that failed.
pulled the gate's polling loop into a helper and had boot recovery ask through it too.
one cost: on a boot where the trial is exhausted and robotd isn't answering at all, recovery now waits the health timeout instead of 2s before reverting. that's the wait the apply gate already does on the same question. board-test is unaffected, its fixture uses probe = none.