Skip to content

Bench: Disable ASLR on x86_64 to stabilize cycle counts #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mkannwischer wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Bench: Disable ASLR on x86_64 to stabilize cycle counts #1091

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/bench.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,34 +139,40 @@ jobs:
cflags: "-flto -DMLD_FORCE_AARCH64"
ldflags: "-flto"
perf: PERF
# --addr-no-randomize is a workaround for benchmark instability on x86_64
# TODO: Investigate cause and remove workaround
- name: AMD EPYC 4th gen (c7a)
ec2_instance_type: c7a.medium
ec2_ami: ubuntu-latest (x86_64)
archflags: -mavx2 -mbmi2 -mpopcnt -maes -march=znver4
cflags: "-flto -DMLD_FORCE_X86_64"
ldflags: "-flto"
perf: PMU
bench_extra_args: -w "setarch --addr-no-randomize"
- name: Intel Xeon 4th gen (c7i)
ec2_instance_type: c7i.metal-24xl
ec2_ami: ubuntu-latest (x86_64)
archflags: -mavx2 -mbmi2 -mpopcnt -maes -march=sapphirerapids
cflags: "-flto -DMLD_FORCE_X86_64"
ldflags: "-flto"
perf: PMU
bench_extra_args: -w "setarch --addr-no-randomize"
- name: AMD EPYC 3rd gen (c6a)
ec2_instance_type: c6a.large
ec2_ami: ubuntu-latest (x86_64)
archflags: -mavx2 -mbmi2 -mpopcnt -maes -march=znver3
cflags: "-flto -DMLD_FORCE_X86_64"
ldflags: "-flto"
perf: PMU
bench_extra_args: -w "setarch --addr-no-randomize"
- name: Intel Xeon 3rd gen (c6i)
ec2_instance_type: c6i.large
ec2_ami: ubuntu-latest (x86_64)
archflags: -mavx2 -mbmi2 -mpopcnt -maes -march=icelake-server
cflags: "-flto -DMLD_FORCE_X86_64"
ldflags: "-flto"
perf: PMU
bench_extra_args: -w "setarch --addr-no-randomize"
uses: ./.github/workflows/bench_ec2_reusable.yml
if: github.repository_owner == 'pq-code-package' && (github.event.label.name == 'benchmark' || github.ref == 'refs/heads/main')
with:
Expand All @@ -179,4 +185,5 @@ jobs:
store_results: ${{ github.repository_owner == 'pq-code-package' && github.ref == 'refs/heads/main' }} # Only store optimized results
name: ${{ matrix.target.name }}
perf: ${{ matrix.target.perf }}
bench_extra_args: ${{ matrix.target.bench_extra_args }}
secrets: inherit
Loading