-
Notifications
You must be signed in to change notification settings - Fork 12
fix(base64): disable base64 utils injections by default #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(base64): disable base64 utils injections by default #14
Conversation
| @@ -1,9 +1,5 @@ | |||
| import 'react-native-url-polyfill/auto'; | |||
| import { NativeModules } from 'react-native'; | |||
| import { atob, btoa } from 'react-native-quick-base64'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also remove the dependency if it's not used anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just updated the PR and removed all refs to react-native-quick-base64
|
@sabaturgay looks like there's a merge conflict in README.md, could you rebase and fix it? |
|
@aqrln thanks a lot for your help with this PR! I think the changes are ready to be merged. What do you think? |
|
@sabaturgay it looks like the lockfile is not up-to-date: |
Related issue: #13