Skip to content

Conversation

@sabaturgay
Copy link

Related issue: #13

@CLAassistant
Copy link

CLAassistant commented Jul 8, 2024

CLA assistant check
All committers have signed the CLA.

@@ -1,9 +1,5 @@
import 'react-native-url-polyfill/auto';
import { NativeModules } from 'react-native';
import { atob, btoa } from 'react-native-quick-base64';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also remove the dependency if it's not used anymore?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just updated the PR and removed all refs to react-native-quick-base64

@aqrln
Copy link
Member

aqrln commented Feb 24, 2025

@sabaturgay looks like there's a merge conflict in README.md, could you rebase and fix it?

@sabaturgay
Copy link
Author

@aqrln thanks a lot for your help with this PR! I think the changes are ready to be merged. What do you think?

@aqrln aqrln added this to the 6.5.0 milestone Mar 6, 2025
@aqrln
Copy link
Member

aqrln commented Mar 6, 2025

@sabaturgay it looks like the lockfile is not up-to-date:

Run yarn install --immutable
➤ YN0000: Yarn detected that the current workflow is executed from a public pull request. For safety the hardened mode has been enabled.
➤ YN0000: It will prevent malicious lockfile manipulations, in exchange for a slower install time. You can opt-out if necessary; check our documentation for more details.

➤ YN0000: · Yarn 4.1.1
➤ YN0000: ┌ Resolution step
Resolution step
➤ YN0000: └ Completed in 7s 461ms
➤ YN0000: ┌ Post-resolution validation
Post-resolution validation
➤ YN0028: -    react-native-quick-base64: "npm:^2.0.8"
➤ YN0028: -"react-native-quick-base64@npm:^2.0.8":
➤ YN0028: -  version: 2.0.8
➤ YN0028: -  resolution: "react-native-quick-base64@npm:2.0.8"
➤ YN0028: -  dependencies:
➤ YN0028: -    base64-js: "npm:^1.5.1"
➤ YN0028: -  peerDependencies:
➤ YN0028: -    react: "*"
➤ YN0028: -    react-native: "*"
➤ YN0028: -  checksum: 10/783c42dd1b3701e211c8afe54781889f113b7fb71fcf5b923313a61368a42be52ec0654e8f34e3e51a8fb6c62a1c7ec7491216631c77177986d3ed52d18111f6
➤ YN0028: -  languageName: node
➤ YN0028: -  linkType: hard
➤ YN0028: -
➤ YN0028: The lockfile would have been modified by this install, which is explicitly forbidden.
➤ YN0000: └ Completed
➤ YN0000: · Failed with errors in 7s 521ms
Error: Process completed with exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants