Skip to content

fix(base64): disable base64 utils injections by default #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sabaturgay wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(base64): disable base64 utils injections by default #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31d18db
fix(base64): disable base64 utils injections by default
sabaturgay May 29, 2024
d973be1
fix(base64): remove all references to react-native-quick-base64
sabaturgay Feb 24, 2025
fd26b0c
Merge branch 'main' into fix/disable-base64-utils-injection
sabaturgay Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ A Prisma engine adaptation for React Native. Please note that this is in [Early
Install `@prisma/client`, `@prisma/react-native` and the `react-native-quick-base64` dependency:

```
npm i --save --save-exact @prisma/client@latest @prisma/react-native@latest react-native-quick-base64
npm i --save --save-exact @prisma/client@latest @prisma/react-native@latest
```

To ensure migration files are copied into the app bundle you need to either enable the Expo plugin or configure ios and Android manually:
Expand Down
1 change: 0 additions & 1 deletion example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
"react-native": "0.73.2",
"react-native-http-bridge-refurbished": "^1.2.9",
"react-native-network-info": "^5.2.1",
"react-native-quick-base64": "^2.0.8",
"react-native-reanimated": "^3.7.2",
"react-native-url-polyfill": "^2.0.0",
"text-encoding": "^0.7.0"
Expand Down
3 changes: 0 additions & 3 deletions example/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import {
View,
} from 'react-native';
import { NetworkInfo } from 'react-native-network-info';
import { atob, btoa } from 'react-native-quick-base64';

import 'react-native-url-polyfill/auto';
import '../global.css';
Expand All @@ -25,8 +24,6 @@ import {
} from './db';

// global.TextEncoder = require('text-encoding').TextEncoder;
global.atob = atob;
global.btoa = btoa;

export default function App() {
const [prismaTime, setPrismaTime] = useState(0);
Expand Down
5 changes: 1 addition & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@
"react": "18.2.0",
"react-native": "0.73.2",
"react-native-builder-bob": "0.23.2",
"react-native-quick-base64": "2.0.8",
"react-native-url-polyfill": "2.0.0",
"tsx": "^4.7.3",
"typescript": "^5.4.5",
Expand All @@ -103,8 +102,7 @@
"@prisma/client": "*",
"expo": ">=49.0.0",
"react": "*",
"react-native": "*",
"react-native-quick-base64": "*"
"react-native": "*"
},
"workspaces": [
"example"
Expand Down Expand Up @@ -176,7 +174,6 @@
}
},
"dependencies": {
"react-native-quick-base64": "^2.0.8",
"react-native-url-polyfill": "^2.0.0"
}
}
4 changes: 0 additions & 4 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
import 'react-native-url-polyfill/auto';
import { NativeModules } from 'react-native';
import { atob, btoa } from 'react-native-quick-base64';
Copy link
Member

@aqrln aqrln Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also remove the dependency if it's not used anymore?

Copy link
Author

@sabaturgay sabaturgay Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just updated the PR and removed all refs to react-native-quick-base64


global.atob = atob;
global.btoa = btoa;

export { reactiveHooksExtension } from './ReactiveHooksExtension';
export { reactiveQueriesExtension } from './ReactiveQueriesExtension';
Expand Down
4 changes: 1 addition & 3 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3353,7 +3353,6 @@ __metadata:
react: "npm:18.2.0"
react-native: "npm:0.73.2"
react-native-builder-bob: "npm:0.23.2"
react-native-quick-base64: "npm:2.0.8"
react-native-url-polyfill: "npm:2.0.0"
tsx: "npm:^4.7.3"
typescript: "npm:^5.4.5"
Expand All @@ -3364,7 +3363,6 @@ __metadata:
expo: ">=49.0.0"
react: "*"
react-native: "*"
react-native-quick-base64: "*"
peerDependenciesMeta:
expo:
optional: true
Expand Down Expand Up @@ -13448,7 +13446,7 @@ __metadata:
languageName: unknown
linkType: soft

"react-native-quick-base64@npm:2.0.8, react-native-quick-base64@npm:^2.0.8":
"react-native-quick-base64@npm:^2.0.8":
version: 2.0.8
resolution: "react-native-quick-base64@npm:2.0.8"
dependencies:
Expand Down
Loading