Repository navigation
lightningd: put in nothing for an RBF when no plugin answers rbf_channel - #54
Merged
Merged
Conversation
kwsantiago
force-pushed
the
rbf-hook-default-funding
branch
from
October 19, 2026 00:33
a7f2655 to
93972e7
Compare
kwsantiago
force-pushed
the
rbf-hook-default-funding
branch
from
October 19, 2026 13:05
93972e7 to
9985de0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the peer starts an RBF of a dual-funded open, lightningd asks the
rbf_channelhook how much to put in. With no plugin on that hook (for instance with the funder plugin disabled), it answered withpayload->our_fundingnever set. dualopend then took whatever was in that memory as our contribution: in testing, an absurd total that made it abort the RBF, but a smaller value would be offered as funds we never added inputs for.It now starts at zero, as the
openchannel2payload'saccepter_fundingalready does, so the accepter puts in nothing unless a plugin says otherwise.test_v2_rbf_without_rbf_channel_plugin: an accepter without the funder plugin accepts an RBF and the channel confirms with nothing from it. Without the change it fails withTotal funding_satoshis ... too large.Changelog-None