Skip to content

lightningd: put in nothing for an RBF when no plugin answers rbf_channel #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kwsantiago merged 1 commit into from
Oct 19, 2026
Merged

lightningd: put in nothing for an RBF when no plugin answers rbf_channel #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lightningd/dual_open_control.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2227,6 +2227,7 @@ static void rbf_got_offer(struct subd *dualopend, const u8 *msg)
payload->feerate_our_min = feerate_min(dualopend->ld, NULL);

payload->psbt = NULL;
payload->our_funding = AMOUNT_SAT(0);

/* No error message known (yet) */
payload->err_msg = NULL;
Expand Down
35 changes: 35 additions & 0 deletions tests/test_opening.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2091,6 +2091,41 @@ def test_v2_open_unrecognized_input_before_we_sign(node_factory, bitcoind):
assert not l2.daemon.is_in_log('Broadcasting funding tx {}'.format(funding_txid))


@unittest.skipIf(TEST_NETWORK != 'regtest', 'elementsd doesnt yet support PSBT features we need')
@pytest.mark.openchannel('v2')
def test_v2_rbf_without_rbf_channel_plugin(node_factory, bitcoind):
"""With no plugin on the rbf_channel hook, the accepter puts in nothing.

l2 runs without the funder plugin, so nothing answers rbf_channel and
it must still accept l1's RBF, contributing nothing.
"""
l1, l2 = node_factory.get_nodes(2, opts=[{}, {'disable-plugin': 'funder'}])
l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
chan_amount = 100000
l1.fundwallet(2**24)

res = l1.rpc.fundchannel(l2.info['id'], chan_amount)
chan_id = res['channel_id']
vin = only_one(bitcoind.rpc.decoderawtransaction(res['tx'])['vin'])
l1.daemon.wait_for_log(' to DUALOPEND_AWAITING_LOCKIN')

startweight = 42 + 172 # base weight, funding output
initpsbt = l1.rpc.utxopsbt(chan_amount, find_next_feerate(l1, l2), startweight,
["{}:{}".format(vin['txid'], vin['vout'])],
reservedok=True, excess_as_change=True)['psbt']
bump = l1.rpc.openchannel_bump(chan_id, chan_amount, initpsbt)
update = l1.rpc.openchannel_update(chan_id, bump['psbt'])
assert update['commitments_secured']
l1.rpc.openchannel_signed(chan_id, l1.rpc.signpsbt(update['psbt'])['signed_psbt'])

bitcoind.generate_block(6, wait_for_mempool=1)
for n in (l1, l2):
n.daemon.wait_for_log(' to CHANNELD_NORMAL')
chan = only_one(l1.rpc.listpeerchannels()['channels'])
assert chan['funding_txid'] != res['txid']
assert chan['funding']['remote_funds_msat'] == Millisatoshi(0)


@unittest.skipIf(TEST_NETWORK != 'regtest', 'elementsd doesnt yet support PSBT features we need')
@pytest.mark.openchannel('v2')
def test_v2_funding_spent_before_lockin(node_factory, bitcoind):
Expand Down
Loading