Skip to content

pytest: skip the cancel race tests' race asserts under ASan #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kwsantiago merged 1 commit into from
Oct 19, 2026
Merged

pytest: skip the cancel race tests' race asserts under ASan #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/test_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1555,7 +1555,7 @@ def test_funding_cancel_race(node_factory, bitcoind, executor):
assert num_cancel == len(nodes)

# We should have raced at least once!
if not VALGRIND:
if not VALGRIND and env("ASAN", "0") != "1":
assert num_cancel > 0
assert num_complete > 0

Expand Down Expand Up @@ -1653,7 +1653,7 @@ def test_funding_v2_cancel_race(node_factory, bitcoind, executor):
print("Cancelled {} complete {}".format(num_cancel, num_complete))

# We should have raced at least once!
if not VALGRIND:
if not VALGRIND and env("ASAN", "0") != "1":
assert num_cancel > 0
assert num_complete > 0

Expand Down
Loading