-
Notifications
You must be signed in to change notification settings - Fork 2
Refactor Test Suite Structure, Naming, and Resource Handling in CITYdata #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f161169
addressed issue #214
SikandarEjaz 5279a3f
moved data to `src/test/resources`, issue #214
SikandarEjaz 7897186
removed duplicate data, issue #214
SikandarEjaz bd1b48e
removed FireBaseTest - issue #214
SikandarEjaz 08cb388
added more producers sanity tests
SikandarEjaz 18df70f
moved test data and added more producers sanity tests - issue #241
SikandarEjaz 0d5be14
Added sanity tests for two producers -EnvironmentalProducer, RoomOccu…
MinetteMeyo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,7 +40,7 @@ public class EnergyConsumptionProducer extends AbstractProducer<JsonArray> imple | |
| public void setCity(String city) { | ||
| this.city = city; | ||
| if (this.city != null) { | ||
| this.cityConsumptionDataset = "docs/examples/data/" + this.city + "_energy_consumption.parquet"; | ||
| this.cityConsumptionDataset = "./src/test/resources/" + this.city + "_energy_consumption.parquet"; | ||
| } else { | ||
| throw new InvalidParameterException("Please provide a city name to the producer."); | ||
| } | ||
|
|
@@ -58,7 +58,7 @@ public void setClientId(Integer clientId) { | |
| this.clientId = clientId; | ||
| } | ||
|
|
||
| private String buildQuery() { | ||
| public String buildQuery() { | ||
| final Object[] arr = new Object[4]; | ||
| final String baseQuery = "SELECT Identifiant as clientId, dateinterval as timestamp, energieactivelivree_kwh as consumptionKwh FROM '%s'"; | ||
| String preparedStmt = baseQuery + " WHERE Identifiant is not null"; | ||
|
|
@@ -82,7 +82,7 @@ private String buildQuery() { | |
| return String.format(preparedStmt, arr); | ||
| } | ||
|
|
||
| private void validateParams() { | ||
| public void validateParams() { | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure about making |
||
| final int MAX_QUERY_DAYS = 30; | ||
| final LocalDateTime localStartDate = StringUtils.parseDate(this.startDatetime); | ||
| final LocalDateTime localEndDate = StringUtils.parseDate(this.endDatetime); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about making
buildQuery()method public. But we need to do this because of the sanity tests.