Refactor Test Suite Structure, Naming, and Resource Handling in CITYdata#215
Refactor Test Suite Structure, Naming, and Resource Handling in CITYdata#215SikandarEjaz merged 7 commits intodevelopfrom
Conversation
| } | ||
|
|
||
| private void validateParams() { | ||
| public void validateParams() { |
There was a problem hiding this comment.
I'm not sure about making validateParams() method public. But we need to do this because of the sanity tests.
| } | ||
|
|
||
| private String buildQuery() { | ||
| public String buildQuery() { |
There was a problem hiding this comment.
I'm not sure about making buildQuery() method public. But we need to do this because of the sanity tests.
MinetteMeyo
left a comment
MinetteMeyo
left a comment
There was a problem hiding this comment.
We reviewed your changes together. The only point I’m still unsure about is changing the visibility of the two methods in EnergyConsumptionProducer -validateParams() and buildQuery()- from private to public. I’ll approve the PR for now, and we can discuss this later with Yann.
Perfect, we can work on this in coming days. For now, I am merging the PR. |
2 participants
Addressed issue #214