Skip to content

Name the Forbidden VS Code Files Without a Path the Dead-Path Gate Reads - #3530

Merged
ptr727 merged 1 commit into
developfrom
fix/editor-tasks-dead-path
Oct 27, 2026
Merged

ptr727 merged 1 commit into
developfrom
fix/editor-tasks-dead-path

Conversation

@ptr727

@ptr727 ptr727 commented Oct 27, 2026

Copy link
Copy Markdown
Owner

Summary

Answers #1612. The issue closes on the promotion pull request.

GOVERNANCE.md "Editor and Tasks" named .vscode/settings.json and .vscode/extensions.json to forbid them. The prose gate's dead-path rule reads a backtick span containing a / as a path. It reports that path when git once tracked it and the tree no longer holds it. So every carrier that ever deleted .vscode/settings.json failed the gate as soon as a re-vendor touched the line. This section is verbatim, so the carrier cannot reword it and is held at an old revision.

The sentence now names the files by basename "under .vscode/". The rule is unchanged. path_candidate drops a span with no /, and .vscode/ has no file-shaped last segment, so neither span reaches the deletion check.

Verification

A throwaway repository commits .vscode/settings.json and then deletes it. In that repository, prose_lint.py --check dead-path:

  • on the old GOVERNANCE.md: GOVERNANCE.md:354: dead-path: path '.vscode/settings.json' is deleted from this tree, exit 1
  • on the new GOVERNANCE.md: no finding, exit 0

The full prose gate on GOVERNANCE.md and spec/validate.py both pass.

🤖 Generated with Claude Code

"Editor and Tasks" named `.vscode/settings.json` to forbid it, and the
prose gate's dead-path rule reads a path git once tracked and the tree no
longer holds as a stale mention. Every carrier that ever deleted that
file therefore failed the gate on a re-vendor of this verbatim section.
Naming the files by basename under `.vscode/` states the same rule in a
form the gate does not read as a path.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 27, 2026 21:54
@ptr727

ptr727 commented Oct 27, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 2f98aa766de590deb4eb7126310141bf0514a2b7, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues were identified, and the policy is preserved while avoiding false-positive dead-path findings.

No open issues 🎉

What changed in this PR

This pull request updates the canonical governance wording so forbidden VS Code files do not trigger false-positive dead-path findings in downstream repositories.

Changes:

  • Names settings.json and extensions.json by basename under .vscode/.
  • Preserves the existing prohibition and .code-workspace configuration policy.
  • Keeps the wording compatible with the existing prose gate.
File Description
GOVERNANCE.md Adjusts the verbatim Editor and Tasks guidance to avoid false-positive dead-path findings.

Review effort: Lite

@codecov

codecov Bot commented Oct 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.58%. Comparing base (f0c1d25) to head (2f98aa7).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3530   +/-   ##
========================================
  Coverage    81.58%   81.58%           
========================================
  Files           26       26           
  Lines         8972     8972           
========================================
  Hits          7320     7320           
  Misses        1652     1652           
Flag Coverage Δ
python-3.13 81.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727
ptr727 merged commit b3cc42b into develop Oct 27, 2026
14 checks passed
@ptr727
ptr727 deleted the fix/editor-tasks-dead-path branch October 27, 2026 22:06
ptr727 added a commit that referenced this pull request Oct 27, 2026
…n-Config Python (#3535)

## Summary

Promotes `develop` to `main`:

- #3530: `GOVERNANCE.md` "Editor and Tasks" names the forbidden VS Code
files by basename under `.vscode/`. A carrier that once deleted
`.vscode/settings.json` can then re-vendor the section without the prose
gate's `dead-path` rule refusing it. This fixes the defect #1612
describes (that issue is closed and is referenced here, not closed by
this PR).
- #3532: HomeAutomation-Config's registry entry declares `python`, its
eight `pythonDirectories`, and `CODECOV_TOKEN`, with a driftNote
recording the maintainer's decision. The pre-commit hooks rollout
tracker rows are updated to match.

Closes #2255

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants