qcci: Remove client lock around xport close in release_async - #12
Merged
Deepak Kumar Singh (quic-deesin) merged 1 commit intoJan 5, 2026
Merged
Deepak Kumar Singh (quic-deesin) merged 1 commit into
Deepak Kumar Singh (quic-deesin) merged 1 commit into
Conversation
In qmi_client_release_async(), only hold clnt->lock long enough to mark non-notifier clients as not accepting transactions, clean up pending transactions, save the release callback, and clear clnt->xport_handle. Call xport->ops->close() after dropping clnt->lock using the saved xport_handle. Moving xport->close() out of the client lock avoids a lock ordering inversion with the control thread, which can hold xport_list_lock while invoking CCI callbacks during transport teardown. Signed-off-by: Pranav Mahesh Phansalkar <pranav.phansalkar@oss.qualcomm.com>
Deepak Kumar Singh (quic-deesin)
approved these changes
Jan 5, 2026
Deepak Kumar Singh (quic-deesin)
merged commit Jan 5, 2026
88615d0
into
qualcomm:development
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In qmi_client_release_async(), only hold clnt->lock long enough to mark non-notifier clients as not accepting transactions, clean up pending transactions, save the release callback, and clear clnt->xport_handle. Call xport->ops->close() after dropping clnt->lock using the saved xport_handle.
Moving xport->close() out of the client lock avoids a lock ordering inversion with the control thread, which can hold xport_list_lock while invoking CCI callbacks during transport teardown.