Skip to content

qcci: Remove client lock around xport close in release_async #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Deepak Kumar Singh (quic-deesin) merged 1 commit into from
Jan 5, 2026
Merged

qcci: Remove client lock around xport close in release_async #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions qcci/qcci_common.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2071,13 +2071,15 @@ qmi_cci_error_type qmi_cci_release_async(
void *release_cb_data)
{
qcci_client_type *clnt;
void *xport_handle;

clnt = qcci_client_get_ref(user_handle, 1);
if (!clnt)
return QMI_CLIENT_INVALID_CLNT;

QCCI_OS_LOCK(&clnt->lock);

xport_handle = clnt->xport_handle;
if (clnt->category != QCCI_NOTIFIER_CLIENT) {
/* From now on all calls to qcci_send will fail */
clnt->info.client.accepting_txns = 0;
Expand All @@ -2087,11 +2089,10 @@ qmi_cci_error_type qmi_cci_release_async(

clnt->release_cb = release_cb;
clnt->release_cb_data = release_cb_data;

qcci_xport_ops->close(clnt->xport_handle);
clnt->xport_handle = NULL;

QCCI_OS_UNLOCK(&clnt->lock);
qcci_xport_ops->close(xport_handle);

qcci_client_put_ref(clnt);

Expand Down
Loading