Repository navigation
test(self-update): compare install budgets with pytest.approx - #12
Merged
Merged
Conversation
The cold-target budget is computed as (deadline - now) in float seconds and can land one ULP under 900 when time.monotonic() is large, failing the exact list comparison on long-running CI hosts (899.9999999999999 != 900). Inherited from upstream 956e789.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only fix for a CI flake inherited from upstream (956e789).
_run_managed_upgradecomputes the cold-target install budget asfallback_deadline - time.monotonic()withfallback_deadline = now + 900. In floats,(now + 900) - nowcan be899.9999999999999whentime.monotonic()is large, so the exactbudgets == [90, 900]assertion fails intermittently (seen on #9 CI).Change: compare with
pytest.approx. No production code touched.Verification: ruff format/check clean;
pytest tests/unit/infra/setup/test_self_update.py -k cold_target4 passed.Upstream candidate: same assertion exists on upstream/develop.