Skip to content

test(self-update): compare install budgets with pytest.approx #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ra-co88 merged 1 commit into from
Oct 12, 2026
Merged

test(self-update): compare install budgets with pytest.approx #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/unit/infra/setup/test_self_update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1168,7 +1168,10 @@ def cold_install(
monkeypatch.setattr(self_update, "_run_install_cmd", cold_install)
result = self_update._run_managed_upgrade(version="1.0.2b5", locale="en")
assert result.success is (portable and installer == "pip")
assert budgets == ([90, 900] if portable and installer == "pip" else [90])
# The budget is (deadline - now) in float seconds, so it can land a ULP
# under 900 when time.monotonic() is large (long-running CI hosts).
expected = [90, 900] if portable and installer == "pip" else [90]
assert budgets == pytest.approx(expected)


# The desktop launcher compares versions with its own Go implementation
Expand Down
Loading