Skip to content

feat: add rapids-artifact-name#253

Merged
rapids-bot[bot] merged 3 commits into
rapidsai:mainfrom
gforsyth:rapids-artifact-name
Apr 28, 2026
Merged

feat: add rapids-artifact-name#253
rapids-bot[bot] merged 3 commits into
rapidsai:mainfrom
gforsyth:rapids-artifact-name

Conversation

@gforsyth
Copy link
Copy Markdown
Contributor

@gforsyth gforsyth commented Apr 28, 2026

This is part of rapidsai/build-planning#270

It adds a new tool rapids-artifact-name that handles naming more consistently.

The arguments are:

rapids-artifact-name package_type package_name repo --cuda [version] --py [version] --stable --pure

--stable, --py [version], and --pure are mutually exclusive and are only available when naming python artifacts.

> rapids-artifact-name conda_cpp librmm rmm --cuda 12.9
rmm_conda_cpp_librmm_amd64_cu12

> rapids-artifact-name wheel_cpp librmm rmm --cuda 12.9
rmm_wheel_cpp_librmm_amd64_cu12

> rapids-artifact-name conda_python pylibcudf cudf --cuda 13.1 --stable
cudf_conda_python_pylibcudf_amd64_abi3_cu13

> rapids-artifact-name wheel_python pylibcudf cudf --cuda 13.1 --stable
cudf_wheel_python_pylibcudf_amd64_abi3_cu13

> rapids-artifact-name wheel_python dask-cudf cudf --cuda 13.1 --pure
cudf_wheel_python_dask-cudf_amd64_pure_cu13

> rapids-artifact-name wheel_python dask-cudf cudf --pure
cudf_wheel_python_dask-cudf_amd64_pure

I tested this in rapidsai/rmm#2370 by vendoring the script as written there (along with some related small changes to shared-workflows to allow overriding artifact names in the conda cpp builds)

@gforsyth gforsyth requested a review from a team as a code owner April 28, 2026 18:36
@gforsyth gforsyth requested review from AyodeAwe and removed request for a team April 28, 2026 18:36
refactor: don't include cpython base in cpp artifacts

fix: error if user tries to use `--py` with `cpp` artifact

cleanup
@gforsyth gforsyth force-pushed the rapids-artifact-name branch from b646476 to 7ffa902 Compare April 28, 2026 18:40
@AyodeAwe
Copy link
Copy Markdown
Contributor

Do we have a tracking issue for this work? This is so that the surrounding context behind the effort is easily reachable.

@gforsyth
Copy link
Copy Markdown
Contributor Author

Do we have a tracking issue for this work? This is so that the surrounding context behind the effort is easily reachable.

Sorry @AyodeAwe -- I tried to cancel the gh pr create call but it instead created the bare PR - I've updated the description!

Copy link
Copy Markdown
Contributor

@AyodeAwe AyodeAwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Two non-blocking suggestions before merge:

  1. README: the "Managing CI artifacts" section lists tools with one-liners (including rapids-package-name). Worth adding rapids-artifact-name so it's discoverable?
  2. Mark rapids-package-name as deprecated: build-planning#270 already tracks the migration path. While that's in flight, would help to add a header note to the old script pointing readers to the new one, so we don't pick up new callers on the deprecated tool?

rapids-bot Bot pushed a commit to rapidsai/shared-workflows that referenced this pull request Apr 28, 2026
This is part of rapidsai/build-planning#270.

I'm rolling out a new `rapids-artifact-name` tool to make our artifact names more consistent - part of the first phase of this is overriding the "default" names that get created by `shared-workflows`.  I previously added the capability to override the artifact name from within the ci scripts for the stable ABI work, but that only covered the `python-build` workflows, this extends that capability to the `cpp-build` workflows.

Tested this in rapidsai/rmm#2370 along with the vendored version of the script from rapidsai/gha-tools#253

Authors:
  - Gil Forsyth (https://github.com/gforsyth)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #528
@gforsyth
Copy link
Copy Markdown
Contributor Author

  • README: the "Managing CI artifacts" section lists tools with one-liners (including rapids-package-name). Worth adding rapids-artifact-name so it's discoverable?

  • Mark rapids-package-name as deprecated: build-planning#270 already tracks the migration path. While that's in flight, would help to add a header note to the old script pointing readers to the new one, so we don't pick up new callers on the deprecated tool?

Good suggestions! I've added both of them (I removed the rapids-package-name example from the README to avoid confusion)

@gforsyth
Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot rapids-bot Bot merged commit 48046ee into rapidsai:main Apr 28, 2026
3 checks passed
@gforsyth gforsyth deleted the rapids-artifact-name branch April 28, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants