feat: add rapids-artifact-name#253
Conversation
refactor: don't include cpython base in cpp artifacts fix: error if user tries to use `--py` with `cpp` artifact cleanup
b646476 to
7ffa902
Compare
|
Do we have a tracking issue for this work? This is so that the surrounding context behind the effort is easily reachable. |
Sorry @AyodeAwe -- I tried to cancel the |
AyodeAwe
left a comment
There was a problem hiding this comment.
LGTM. Two non-blocking suggestions before merge:
- README: the "Managing CI artifacts" section lists tools with one-liners (including
rapids-package-name). Worth addingrapids-artifact-nameso it's discoverable? - Mark
rapids-package-nameas deprecated: build-planning#270 already tracks the migration path. While that's in flight, would help to add a header note to the old script pointing readers to the new one, so we don't pick up new callers on the deprecated tool?
This is part of rapidsai/build-planning#270. I'm rolling out a new `rapids-artifact-name` tool to make our artifact names more consistent - part of the first phase of this is overriding the "default" names that get created by `shared-workflows`. I previously added the capability to override the artifact name from within the ci scripts for the stable ABI work, but that only covered the `python-build` workflows, this extends that capability to the `cpp-build` workflows. Tested this in rapidsai/rmm#2370 along with the vendored version of the script from rapidsai/gha-tools#253 Authors: - Gil Forsyth (https://github.com/gforsyth) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #528
Good suggestions! I've added both of them (I removed the |
|
/merge |
This is part of rapidsai/build-planning#270
It adds a new tool
rapids-artifact-namethat handles naming more consistently.The arguments are:
rapids-artifact-name package_type package_name repo --cuda [version] --py [version] --stable --pure--stable,--py [version], and--pureare mutually exclusive and are only available when namingpythonartifacts.I tested this in rapidsai/rmm#2370 by vendoring the script as written there (along with some related small changes to
shared-workflowsto allow overriding artifact names in the conda cpp builds)