Add default "overflow: visible" to Text#451
Merged
Merged
Conversation
iOS and Android both historically clip everything outside the bounds of the paragraph/top-level text element. This includes clipping content, when `line-height` would set the bounds to be smaller than the text to be drawn. This is equivalent to setting `overflow: 'hidden'` manually on a paragraph. Changing this default behavior in React Native is scary and breaking, but with Facsimile, it can be controlled with opt-in `overflow: visible`, for web style clipping. Let's set default `overflow: 'visible'`, so that when using web interface, we don't clip the bounds of text (like web doesn't).
Contributor
Author
|
@mellyeliu this should prevent existing line height clipping issue on new Android text stack rolling out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS and Android both historically clip everything outside the bounds of the paragraph/top-level text element. This includes clipping content, when
line-heightwould set the bounds to be smaller than the text to be drawn. This is equivalent to settingoverflow: 'hidden'manually on a paragraph.Changing this default behavior in React Native is scary and breaking and not something we are taking on right now, but with Facsimile/PreparedLayoutTextView on Android, it can be controlled with opt-in
overflow: visible, for web style clipping.This change defaults to
overflow: 'visible'to get that web style behavior by default (e.g. no clipping the bounds ofTextView/<p>whenline-heightmakes text larger than the bounds.