Skip to content

Add default "overflow: visible" to Text #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
necolas merged 1 commit into from
Feb 13, 2026
Merged

Add default "overflow: visible" to Text #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 46 additions & 11 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 7 additions & 0 deletions packages/react-strict-dom/src/native/modules/createStrictDOMTextComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,13 @@ export function createStrictDOMTextComponent<T, P: StrictProps>(
disableUserSelect ? { userSelect: 'none' } : null
);

// Native components historically clip text. Opt into web-style default of
// visible overflow by default
if (nativeProps.style?.overflow == null) {
nativeProps.style = nativeProps.style ?? {};
nativeProps.style.overflow = 'visible';
}

// Use Animated components if necessary
if (nativeProps.animated === true) {
NativeComponent = ReactNative.Animated.Text;
Expand Down
2 changes: 2 additions & 0 deletions packages/react-strict-dom/tests/compat/__snapshots__/compat-test.native.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ exports[`<compat.native> "as" equals "span": as=span 1`] = `
style={
{
"color": "blue",
"overflow": "visible",
"userSelect": "none",
}
}
Expand Down Expand Up @@ -85,6 +86,7 @@ exports[`<compat.native> nested: nested 1`] = `
{
"boxSizing": "content-box",
"color": "red",
"overflow": "visible",
"position": "static",
}
}
Expand Down
17 changes: 17 additions & 0 deletions .../react-strict-dom/tests/contexts/__snapshots__/contexts-ThemeProvider-test.native.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ exports[`<contexts.*> <ThemeProvider> css variable declaration inside a media qu
style={
{
"boxSizing": "content-box",
"overflow": "visible",
"position": "static",
"width": 42,
}
Expand All @@ -20,6 +21,7 @@ exports[`<contexts.*> <ThemeProvider> defines global custom properties 1`] = `
style={
{
"boxSizing": "content-box",
"overflow": "visible",
"position": "static",
}
}
Expand All @@ -33,6 +35,7 @@ exports[`<contexts.*> <ThemeProvider> defines global custom properties 1`] = `
"backgroundColor": "red",
"boxSizing": "content-box",
"color": "red",
"overflow": "visible",
"position": "static",
}
}
Expand All @@ -50,6 +53,7 @@ exports[`<contexts.*> <ThemeProvider> kebab case string var to camel case 1`] =
{
"boxSizing": "content-box",
"color": "red",
"overflow": "visible",
"position": "static",
}
}
Expand All @@ -60,6 +64,7 @@ exports[`<contexts.*> <ThemeProvider> kebab case string var to camel case 1`] =
{
"boxSizing": "content-box",
"color": "red",
"overflow": "visible",
"position": "static",
}
}
Expand Down Expand Up @@ -113,6 +118,7 @@ exports[`<contexts.*> <ThemeProvider> rgb(a) function with args applied through
{
"boxSizing": "content-box",
"color": "rgb(24, 48, 96)",
"overflow": "visible",
"position": "static",
}
}
Expand All @@ -123,6 +129,7 @@ exports[`<contexts.*> <ThemeProvider> rgb(a) function with args applied through
{
"boxSizing": "content-box",
"color": "rgba(24, 48, 96, 0.5)",
"overflow": "visible",
"position": "static",
}
}
Expand All @@ -137,6 +144,7 @@ exports[`<contexts.*> <ThemeProvider> rgba function with args applied through mu
{
"boxSizing": "content-box",
"color": "rgba(255, 96, 16, 0.42)",
"overflow": "visible",
"position": "static",
}
}
Expand All @@ -151,6 +159,7 @@ exports[`<contexts.*> <ThemeProvider> string var 1`] = `
"boxSizing": "content-box",
"color": "red",
"opacity": 0.25,
"overflow": "visible",
"position": "static",
}
}
Expand All @@ -164,6 +173,7 @@ exports[`<contexts.*> <ThemeProvider> string var and falls back to a default val
{
"boxSizing": "content-box",
"color": "rgb(255,255,255)",
"overflow": "visible",
"position": "static",
}
}
Expand All @@ -177,6 +187,7 @@ exports[`<contexts.*> <ThemeProvider> string var and falls back to default value
{
"boxSizing": "content-box",
"color": "red",
"overflow": "visible",
"position": "static",
}
}
Expand Down Expand Up @@ -217,6 +228,7 @@ exports[`<contexts.*> <ThemeProvider> string var with a default value 1`] = `
{
"boxSizing": "content-box",
"color": "red",
"overflow": "visible",
"position": "static",
}
}
Expand All @@ -227,6 +239,7 @@ exports[`<contexts.*> <ThemeProvider> string var with a default value 1`] = `
{
"boxSizing": "content-box",
"color": "blue",
"overflow": "visible",
"position": "static",
}
}
Expand All @@ -242,6 +255,7 @@ exports[`<contexts.*> <ThemeProvider> string var with a default value containing
{
"boxSizing": "content-box",
"color": "rgb(0,0,0)",
"overflow": "visible",
"position": "static",
}
}
Expand All @@ -252,6 +266,7 @@ exports[`<contexts.*> <ThemeProvider> string var with a default value containing
{
"boxSizing": "content-box",
"color": "rgb(1 , 1 , 1)",
"overflow": "visible",
"position": "static",
}
}
Expand All @@ -265,6 +280,7 @@ exports[`<contexts.*> <ThemeProvider> textShadow with nested/multiple vars 1`] =
style={
{
"boxSizing": "content-box",
"overflow": "visible",
"position": "static",
"textShadowColor": "red",
"textShadowOffset": {
Expand All @@ -283,6 +299,7 @@ exports[`<contexts.*> <ThemeProvider> transform with nested/multiple vars 1`] =
style={
{
"boxSizing": "content-box",
"overflow": "visible",
"position": "static",
"transform": [
{
Expand Down
2 changes: 2 additions & 0 deletions ...act-strict-dom/tests/contexts/__snapshots__/contexts-ViewportProvider-test.native.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ exports[`<contexts.*> <ViewportProvider> all CSS lengths are scaled according to
"boxSizing": "content-box",
"fontSize": 24,
"lineHeight": 24,
"overflow": "visible",
"position": "static",
}
}
Expand All @@ -42,6 +43,7 @@ exports[`<contexts.*> <ViewportProvider> all CSS lengths are scaled according to
{
"boxSizing": "content-box",
"fontSize": 18,
"overflow": "visible",
"position": "static",
}
}
Expand Down
4 changes: 4 additions & 0 deletions packages/react-strict-dom/tests/css/__snapshots__/css-create-queries-test.native.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ exports[`css.create(): @media query does not match (prefers-color-scheme: dark)
"borderColor": "green",
"boxSizing": "content-box",
"color": "black",
"overflow": "visible",
"position": "static",
}
`;
Expand All @@ -16,6 +17,7 @@ exports[`css.create(): @media query does not match (prefers-color-scheme: light)
"borderColor": "darkgreen",
"boxSizing": "content-box",
"color": "white",
"overflow": "visible",
"position": "static",
}
`;
Expand All @@ -26,6 +28,7 @@ exports[`css.create(): @media query matches (prefers-color-scheme: dark) 1`] = `
"borderColor": "darkgreen",
"boxSizing": "content-box",
"color": "white",
"overflow": "visible",
"position": "static",
}
`;
Expand All @@ -36,6 +39,7 @@ exports[`css.create(): @media query matches (prefers-color-scheme: light) 1`] =
"borderColor": "green",
"boxSizing": "content-box",
"color": "black",
"overflow": "visible",
"position": "static",
}
`;
Loading