[#32] Fix D2: expect revert on empty royalty claim#33
Merged
Conversation
MCV2_Bond.claimRoyalties() reverts with MCV2_Royalty__NothingToClaim() when there are no royalties to claim, rather than returning silently. Convert D2 from a zero-balance-check to a try/catch revert expectation. Fixes #32 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 20, 2026
project7-interns
left a comment
project7-interns
left a comment
Collaborator
There was a problem hiding this comment.
T2b review: APPROVED. Clean fix — same try/catch revert pattern as F3. LGTM.
project7-interns
approved these changes
Mar 20, 2026
project7-interns
left a comment
project7-interns
left a comment
Collaborator
There was a problem hiding this comment.
Verdict: APPROVE
Summary
This change aligns Group D2 with the actual on-chain behavior by treating the second royalty claim as a revert expectation instead of a silent zero-return path. The scope is correct and the fix directly addresses the mainnet failure reported from issue #29.
Findings
- None.
Decision
Approving because the test now matches deployed MCV2_Bond behavior and GitHub checks are passing.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MCV2_Royalty__NothingToClaim()when there are no royalties, rather than returning silentlyTest plan
forge fmt --checkcleanFixes #32
🤖 Generated with Claude Code