Skip to content

[#32] Fix D2: expect revert on empty royalty claim #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
realproject7 merged 1 commit into from
Mar 20, 2026
Merged

[#32] Fix D2: expect revert on empty royalty claim #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions script/E2ETest.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,13 +391,13 @@ contract E2ETest is Script {
// Serialize royalty results
vm.serializeUint(resultsJson, "royaltiesClaimed", royaltyClaimed);

// D2: Claim again - should return 0
balBefore = PL_TEST.balanceOf(deployer);
BOND.claimRoyalties(address(PL_TEST));
uint256 royaltyClaimed2 = PL_TEST.balanceOf(deployer) - balBefore;
require(royaltyClaimed2 == 0, "D2: double-claim should return 0");
console.log("[D2] Claim royalties again (empty) PASS amount=%d", royaltyClaimed2);
scenariosPassed++;
// D2: Claim again - should revert with MCV2_Royalty__NothingToClaim()
try BOND.claimRoyalties(address(PL_TEST)) {
revert("D2: should have reverted on empty claim");
} catch {
console.log("[D2] Empty claim reverts PASS (MCV2_Royalty__NothingToClaim)");
scenariosPassed++;
}
}

// ===================================================================
Expand Down