Repository navigation
test: observe Esplora script classes on the broadcast journey - #1020
Merged
Merged
Conversation
GET /tx scriptpubkey_type, genesis previousblockhash, and the empty fee-estimate response now sit on esplora_broadcast_visible_in_rpc_and_electrum. The units those beats fail when inverted are deleted.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
esplora_broadcast_visible_in_rpc_and_electrumnow reads script classes, the genesis block, and the empty fee-estimate response off the node it already runs.GET /txassertsscriptpubkey_type, and the OP_TRUE output has no address.GET /block/<genesis>assertspreviousblockhashis null.GET /fee-estimatesstays 503 withfee estimates unavailablewhile the estimator has no target.p2pkh_fields,p2wpkh_fields,p2tr_fields,p2sh_p2wpkh_outer_is_p2sh,unknown_op_true,p2pk_type,p2wsh_op_return_and_bare_multisig_types,fee_routes_do_not_invent_an_estimate,resolve_address_sh_and_block_summary_surface.Test plan
cargo test -p rbitcoin-test --test cross_surface esplora_broadcast_visible_in_rpc_and_electrumcargo test --workspace,ci-os-smoke.sh)