Repository navigation
test: fold conf fields and mempool rejects onto existing journeys - #1022
Merged
Merged
Conversation
operator_conf_and_argv now checks --electrum-max-subs, --esplora-block-template, and a conf error that names the file and line. Mempool life already rejects duplicate inputs, a missing coin, a low feerate, and a libre annex. The sigop journey already records P2SH and P2WSH sigop cost. Those units are deleted.
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move session observations that
operator_conf_and_argv,mempool_accept_life, andsigop_adjusted_size_budget_and_reopenalready produce off the small units that repeated them.operator_conf_and_argvasserts--electrum-max-subs=5,--esplora-block-template=1, and abad.conf:1conf error.--check-blocksand--prefill-compactwere already on that test.mempool_accept_lifealready returnsInputsDuplicate,Orphaned,Policy("min relay fee"), andPolicy("libre annex").sigop_adjusted_size_budget_and_reopenalready records P2SH sigop cost 8 and P2WSH sigop cost 2.Deleted:
electrum_max_subs_cli_conf_and_bounds,max_sh_creates_and_esplora_block_template_cli_hyphens,conf_error_names_the_file_and_line,check_blocks_apply_kv_zero_is_all,prefillcompact_cli_conf_default_on,reject_duplicate_inputs,reject_when_provider_has_no_unspent_coin,reject_low_feerate,annex_reject,libre_rejects_bad_annex,accept_tx_records_full_sigop_cost_for_p2sh_and_p2wsh.Esplora script-class beats stay on #1020.
Test plan
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo deny check./scripts/ast-grep.shcargo test --workspace --quiet(oneend_of_ibd_sh_interruptrace failed in the suite and passed alone; this diff does not touch that test)./scripts/ci-os-smoke.shoperator_conf_and_argv,mempool_accept_life,sigop_adjusted_size_budget_and_reopen