Repository navigation
test: fold conf apply_kv setters onto operator_conf_and_argv - #1023
Merged
Merged
Conversation
The journey now checks a zero rpc work queue, datadir, unknown keys including blocksdir, a duplicate listen, an rpc socket path, and a tor control password. Those units are deleted.
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
operator_conf_and_argvnow checks six conf setters that previously lived only in small units:--rpc-work-queue=0keeps the finite default queue, and4stores 4apply_kv("datadir")sets the path, and an unknown key is not an errorblocks_dir,blocks-dir, andblocksdirstay unknownlistenbind isDuplicate binding configurationrpc_socketmoves the socket path and rejects an empty pathpwis storedThose units are deleted. No new
#[test].Local CI except coverage passed (fmt, clippy
-D warnings, deny, ast-grep, workspace tests, os-smoke).end_of_ibd_sh_interruptfailed once in the full suite and passed on a solo rerun. That journey is not a destination here.Test plan
cargo test -p rbitcoin-node --lib operator_conf_and_argvqc,test,windows,macos,coverage