Repository navigation
test: fold client param edges onto rpc_regtest_from_genesis - #1038
Merged
Merged
Conversation
Ten units already speak to a regtest hub through dispatch. The genesis journey opens that hub, so help, stop, the waiters, signet challenge, decode, and param errors run on its client. Stop and the network field are restored before the later chain beats.
rearden-grok
Bot
force-pushed
the
test/rpc-client-param-edges
branch
from
October 16, 2026 19:54
63553a1 to
be46728
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rpc_regtest_from_genesis. They already assert throughdispatchon a regtest hub, and that journey opens the hub.helptext,stopand the three waiters, the signet challenge and an unknown filter type, raw decode andvalidateaddress, unknown named parameters, JSON type errors, and junk-hexTX decode failed.stopis cleared andctx.networkis put back to regtest before the later chain beats. The tip stays at genesis. No second hub.Test plan
cargo test -p rbitcoin-rpc rpc_regtest_from_genesis -- --quietcargo clippy -p rbitcoin-rpc --all-targets -- -D warnings