Repository navigation
Conversation
openai migrated its HTTP client from httpx (1.x) to httpx2 (2.x, a separate distribution). Backport master's fix so the lock tests accept either family for unpinned openai. The openai==1.82.0 constraints test still expects httpx. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>
Use a version-compatible HTTP mock for OpenAI 1.x/2.x and 3.x. Select httpx or httpx2 and inject MockTransport through OpenAI's public http_client interface, avoiding real requests and private SDK fields. Signed-off-by: Jon Burdo <jon@jonburdo.com>
Post-Codefreeze Gatekeeper — FAILED (evaluation)
Target branch: ❌ The following issues were found:
After resolving issues, push a commit, re-edit the PR description, or add the |
This takes the change to: mlflow/tracing/processor/inference_table.py From commit: dc391d3 See mlflow#22867 Without this the upgraded opentelemetry-sdk version results in the following error: AttributeError: 'InferenceTableSpanProcessor' object has no attribute '_metrics' Signed-off-by: Jon Burdo <jon@jonburdo.com>
Signed-off-by: Jon Burdo <jon@jonburdo.com>
Signed-off-by: Jon Burdo <jon@jonburdo.com>
There was a problem hiding this comment.
🟢 Approval recommended
The compatibility fixes are focused, consistent with the affected APIs, and covered by existing tests.
Pull request overview
Updates the RHOAI 3.3 branch for newer OpenAI, OpenTelemetry, and CI dependency behavior.
Changes:
- Supports OpenAI 3.x’s
httpx2transport. - Initializes OpenTelemetry processors correctly.
- Stabilizes CI networking, dependency constraints, logging assertions, and schema metadata.
File summaries
| File | Description |
|---|---|
tests/tracing/test_otel_logging.py |
Updates exporter error assertion. |
tests/server/auth/test_auth.py |
Uses explicit IPv4 loopback. |
tests/pyfunc/test_model_export_with_class_and_artifacts.py |
Accepts httpx or httpx2 locks. |
tests/genai/utils/test_trace_utils.py |
Adds version-compatible OpenAI mock transport. |
requirements/constraints.txt |
Pins AnyIO below 4.15. |
mlflow/tracing/processor/inference_table.py |
Calls the parent processor initializer. |
mlflow/store/tracking/dbmodels/models.py |
Aligns constraint metadata with migrations. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
HumairAK
approved these changes
Sep 10, 2026
jonburdo
merged commit Sep 10, 2026
247ede3
into
red-hat-data-services:rhoai-3.3
36 of 38 checks passed
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream / Downstream Impact
opendatahub-io/mlflowmlflow/mlflowIf relevant, add any upstream issue or follow-up link here:
RHOAIENG-91803
Testing
Testing details: