Skip to content

chore: update rag image to upstream 1.10 build#29

Merged
Jdubrick merged 1 commit into
redhat-ai-dev:mainfrom
Jdubrick:update-rag-1.10
Jun 12, 2026
Merged

chore: update rag image to upstream 1.10 build#29
Jdubrick merged 1 commit into
redhat-ai-dev:mainfrom
Jdubrick:update-rag-1.10

Conversation

@Jdubrick

Copy link
Copy Markdown
Contributor

What does this PR do?:

  • Updates RAG image to 1.10 build for main branch development for 2.1

Which issue(s) this PR fixes:

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.

  • Tested and Verified

  • Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)

How to test changes / Special notes to the reviewer:

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
@Jdubrick Jdubrick requested a review from a team June 12, 2026 17:28
@qodo-code-review

qodo-code-review Bot commented Jun 12, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0)

Grey Divider


Remediation recommended

1. Stale rag-content causes errors 🐞 Bug ☼ Reliability
Description
llama-stack-configs/config.yaml now hard-codes the RAG SQLite DB to
/rag-content/vector_db/rhdh_product_docs/1.10/faiss_store.db, but make local-up does not refresh
./rag-content. If a developer still has ./rag-content from the previous image/version, the
configured DB file path will be missing and RAG/vector-store operations will error when the backend
tries to open it.
Code

llama-stack-configs/config.yaml[163]

+      db_path: /rag-content/vector_db/rhdh_product_docs/1.10/faiss_store.db
Evidence
The Llama Stack config requires a specific versioned DB file under /rag-content (now
.../1.10/...). Local compose mounts the host ./rag-content into /rag-content, and `make
local-up only starts compose without pulling/updating the RAG content, so a stale ./rag-content`
directory will not contain the required 1.10 path and the configured backend file will be missing.

llama-stack-configs/config.yaml[153-166]
compose/compose.yaml[16-26]
Makefile[30-43]
docs/CONTRIBUTING.md[56-60]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`llama-stack-configs/config.yaml` points `kv_rag.db_path` at a versioned path under `/rag-content/.../1.10/...`, but local compose mounts the host `./rag-content` directory and `make local-up` does not ensure it has been refreshed for the new RAG image. This can lead to confusing runtime failures when the configured DB file does not exist.

## Issue Context
- `make get-rag` is the mechanism that refreshes `./rag-content`, but it is not invoked by `local-up`.
- The compose stack mounts `../rag-content` into the container at `/rag-content`, so any stale local directory is used as-is.

## Fix Focus Areas
- Add a fail-fast validation (or clear warning) in `make local-up` that checks whether the configured DB file exists under `./rag-content` before starting compose, and instructs the user to run `make get-rag` if missing.
- Optionally, update contributing docs to explicitly call out that after updating `RAG_CONTENT_IMAGE`/docs version, you must re-run `make get-rag`.

### Focus references
- Makefile[30-43]
- compose/compose.yaml[16-26]
- llama-stack-configs/config.yaml[153-166]
- docs/CONTRIBUTING.md[56-60]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

chore: bump rag-content image and RHDH docs vector store to 1.10
⚙️ Configuration changes 🕐 Less than 10 minutes

Grey Divider

Walkthroughs

Description
• Bump rag-content container image reference to the upstream 1.10 build.
• Point RHDH product docs vector DB path to the 1.10 dataset.
• Update the configured vector_store_id to match the new rag-content bundle.
Diagram
graph TD
  A["env/default-values.env"] --> B{{"rag-content image 1.10"}} --> C(["RAG content container"]) --> D[("Docs vector DB (1.10)")]
  E["images.yaml"] --> B{{"rag-content image 1.10"}}
  F["llama-stack-configs/config.yaml"] --> C(["RAG content container"]) --> D[("Docs vector DB (1.10)")]

  subgraph Legend
    direction LR
    _f["Config file"] ~~~ _ext{{"Image registry"}} ~~~ _svc(["Service/container"]) ~~~ _db[("Database/store")]
  end
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Single source of truth for image tags
  • ➕ Avoids updating both env/default-values.env and images.yaml for the same image bump
  • ➕ Reduces risk of mismatched image pins across dev/tooling paths
  • ➖ May require small tooling changes (e.g., templating or generating the .env from images.yaml)
  • ➖ Could be overkill if these files serve intentionally separate workflows

Recommendation: The PR’s approach is appropriate for a straightforward image/data bump. Consider consolidating image pinning to one canonical source (or generating one file from the other) to prevent drift between env/default-values.env and images.yaml on future upgrades.

Grey Divider

File Changes

Other (3)
default-values.env Bump RAG_CONTENT_IMAGE to release-1.10 tag +1/-1

Bump RAG_CONTENT_IMAGE to release-1.10 tag

• Updates the default environment variable to point to the rag-content upstream 1.10 build image tag.

env/default-values.env


images.yaml Update rag-content image to release-1.10 +1/-1

Update rag-content image to release-1.10

• Switches the rag-content image reference to the upstream 1.10 build while keeping llama_version unchanged.

images.yaml


config.yaml Point RHDH docs vector store to 1.10 path and ID +2/-2

Point RHDH docs vector store to 1.10 path and ID

• Updates the kv_rag db_path to the /1.10/ dataset location and changes the registered vector_store_id to match the new rag-content bundle.

llama-stack-configs/config.yaml


Grey Divider

Qodo Logo

@michael-valdron michael-valdron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jdubrick Jdubrick merged commit 6d248f7 into redhat-ai-dev:main Jun 12, 2026
3 checks passed
Jdubrick added a commit that referenced this pull request Jun 15, 2026
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants