fix(.golangci.yml): Configure staticcheck to ignore ginkgo/gomega dot-imports#973
Merged
openshift-merge-bot[bot] merged 1 commit intoSep 23, 2025
Conversation
…-imports Signed-off-by: Oliver Gondža <ogondza@gmail.com>
openshift-ci
Bot
added
the
kind/failing-test
anandf
approved these changes
Sep 23, 2025
Member
|
/lgtm |
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anandf The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jgwest
approved these changes
Sep 23, 2025
Member
There was a problem hiding this comment.
LGTM too, thanks @olivergondza! This is a much better solution for this then what I came up with.
(Unfortunately, if you're using VS Code, you may still receive warnings for these in Problems panel, but that's a separate issue)
openshift-merge-bot
Bot
merged commit 78c59ae
into
redhat-developer:master
16 checks passed
olivergondza
added a commit
to olivergondza/gitops-operator
that referenced
this pull request
Feb 13, 2026
Not needed after redhat-developer#973 Signed-off-by: Oliver Gondža <ogondza@gmail.com>
4 tasks
jgwest
pushed a commit
that referenced
this pull request
Feb 18, 2026
Not needed after #973 Signed-off-by: Oliver Gondža <ogondza@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore dot imports for e2e test helpers
What type of PR is this?
What does this PR do / why we need it:
Ginkgo tests uses dot-imports that are reported as undesirable:
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
None
Test acceptance criteria:
How to test changes / Special notes to the reviewer:
Same fix in argocd-operator verified already: argoproj-labs/argocd-operator#1880