chore(scorecard): version bump to v1.51.2#3284
Conversation
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
ReviewFindingsMedium
Low
Info
Previous runReviewFindingsCritical
Low
Previous run (2)ReviewFindingsCritical
Medium
Low
Info
Previous run (3)ReviewFindingsMedium
Low
Info
Previous run (4)ReviewFindingsLow
Info
Previous run (5)ReviewFindingsMedium
Low
Info
Previous run (6)ReviewReason: stale-head The review agent reviewed commit Previous run (7)ReviewFindingsLow
Info
Previous run (8)ReviewFindingsLow
Info
Previous run (9)ReviewFindingsMedium
Low
Info
Previous run (10)ReviewFindingsHigh
Low
Info
Previous run (11)ReviewReason: stale-head The review agent reviewed commit Previous run (12)ReviewReason: stale-head The review agent reviewed commit |
| '@red-hat-developer-hub/backstage-plugin-scorecard': minor | ||
| --- | ||
|
|
||
| Backsatge version bump to v1.51.0 |
There was a problem hiding this comment.
[low] naming-convention
Typo in changeset description: 'Backsatge version bump to v1.51.0' should be 'Backstage version bump to v1.51.0'. This text will appear in the published changelog.
Suggested fix: Fix the typo: Backsatge → Backstage.
4b5264d to
1cd6c9b
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3284 +/- ##
==========================================
- Coverage 50.28% 49.06% -1.22%
==========================================
Files 2260 2260
Lines 85603 85469 -134
Branches 24211 24211
==========================================
- Hits 43044 41936 -1108
- Misses 42058 43032 +974
Partials 501 501
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
1cd6c9b to
6b6556b
Compare
|
|
||
| const displayName = getLocaleDisplayName(locale); | ||
| await this.page.getByRole('link', { name: 'Settings' }).click(); | ||
| await this.page.goto('/settings'); |
There was a problem hiding this comment.
[low] test-inadequate
E2E test replaced UI-element-based navigation with direct page.goto() calls, slightly reducing coverage of navigation link presence/functionality. The affected code is test setup, not the behavior under test.
6b6556b to
aad1405
Compare
|
|
||
| const displayName = getLocaleDisplayName(locale); | ||
| await this.page.getByRole('link', { name: 'Settings' }).click(); | ||
| await this.page.goto('/settings'); |
There was a problem hiding this comment.
[low] test-weakened
switchToLocale switches from role-based link clicking to direct URL navigation (page.goto), bypassing UI element verification. However, this is consistent with existing page.goto() usage in loginAndSetLocale() and openCatalog() in the same file, and the method's core purpose (locale switching) remains fully tested.
|
I think we can get in these PRs before this bump, to avoid rebasing:
|
aad1405 to
6548a29
Compare
|
🤖 Finished Review · ✅ Success · Started 6:27 AM UTC · Completed 6:36 AM UTC |
ce408c2 to
a801f33
Compare
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 6:38 AM UTC · Completed 6:46 AM UTC |
a801f33 to
d5e8787
Compare
|
🤖 Finished Review · ✅ Success · Started 3:54 PM UTC · Completed 4:01 PM UTC |
|
|
||
| const displayName = getLocaleDisplayName(locale); | ||
| await this.page.getByRole('link', { name: 'Settings' }).click(); | ||
| await this.page.goto('/settings'); |
There was a problem hiding this comment.
[low] test behavior change
The switchToLocale method changes from clicking the Settings link (SPA navigation) to page.goto('/settings') (full page navigation), reducing E2E test fidelity for sidebar navigation.
|
🤖 Review · Started 10:29 AM UTC |
|
🤖 Finished Review · ✅ Success · Started 10:29 AM UTC · Completed 10:37 AM UTC |
3291a59 to
fcd25cd
Compare
|
🤖 Finished Review · ✅ Success · Started 12:12 PM UTC · Completed 12:19 PM UTC |
fcd25cd to
3a21168
Compare
|
🤖 Finished Review · ✅ Success · Started 2:28 PM UTC · Completed 2:37 PM UTC |
|
|
🤖 Finished Review · ✅ Success · Started 3:22 PM UTC · Completed 3:32 PM UTC |
| ) : null} | ||
|
|
||
| <Tooltip content={isTooltipEnabled ? tooltipContent : () => null} /> | ||
| <Tooltip |
There was a problem hiding this comment.
[medium] logic-error
Changing the disabled-tooltip fallback from () => null to undefined alters runtime behavior. When tooltipContent is not provided (as in AverageCardComponent), isTooltipEnabled is false and content receives undefined. In recharts v3, passing content={undefined} to causes recharts to render its built-in default tooltip on hover, whereas the old content={() => null} rendered nothing.
Suggested fix: Keep the falsy branch as a function that returns null, or conditionally render the component only when isTooltipEnabled is true.
| ) : null} | ||
|
|
||
| <Tooltip content={isTooltipEnabled ? tooltipContent : () => null} /> | ||
| <Tooltip |
There was a problem hiding this comment.
[low] edge-case
The as never cast on tooltipContent silences type incompatibility between PieTooltipContentProps and recharts v3 Tooltip.content prop type, hiding potential mismatches.
Suggested fix: Align PieTooltipContentProps with recharts v3 TooltipProps so the cast is unnecessary.
|
|
||
| const displayName = getLocaleDisplayName(locale); | ||
| await this.page.getByRole('link', { name: 'Settings' }).click(); | ||
| await this.page.goto('/settings'); |
There was a problem hiding this comment.
[low] test-weakened
switchToLocale changed from clicking UI links to direct page.goto() calls, reducing coverage of the navigation flow.
Suggested fix: Update selectors to match the new Backstage UI rather than bypassing navigation, or add assertions after goto calls.



Hey, I just made a Pull Request!
Scorecard version bump
Fix - https://redhat.atlassian.net/browse/RHIDP-13795
Screen.Recording.2026-06-03.at.8.55.19.PM.mov
How to test
app-config.yamlapp-config.yamlapp-config.yaml✔️ Checklist